v1.4.1 Bug Fixing and Code Refactoring

[LimYiSheng]

Milestone 4
v1.4.1
Resolved #197.

• Removed duplicated Q&A in UserGuide.adoc & updated feature command formats.
• Removed unused command and unused methods/constructors within certain classes
• Edited add and edit command to show only 1 person when duplicate is found
• Updated salary's message constraints
• Ensured that person, schedules and expenses list are always sorted in ascending order by the employee's name, employeeId respectively.
• Fixed add and edit command to not allow overloaded prefixes
• Refactored FilterCommand.java, FilterCommandParser.java codes

---

Milestone 3
v1.3

• Enhanced command filter: It will now take in a new argument of either “asc” or “dsc” to decide whether employees in the filtered list should be sorted in ascending or descending order (by their name)
  -- Command Usage: filter asc/dsc d/DEPARTMENT r/POSITION
• Enhanced command filter: Added listing of currently available departments and/or positions when the output is "0 persons listed"
• Enhanced command find: It now searches for exact name keyword by user and/or employee Id input by user. Therefore, when typing “find alex tan” instead of searching for names that include alex or tan, it now searches for names that include “alex tan” as a whole
• Enhanced command add: Duplicated EmployeeIds, Email or Phone will now be rejected alongside duplicated Name & DateOfBirth and when attempting to do so, GUI will filter to show the person you are trying to duplicate
• Enhanced command edit: When the edit causes duplicated Email or Phone or Name & DateOfBirth, the command will be rejected, and GUI will filter to show the person you are trying to duplicate
• Enhanced method isSamePerson: It will now check for duplicate EmployeeId, Email, Phone, or Name & DateOfBirth
• Enhanced field DateOfBirth: Validity check for dates are now available, it only allows dates from the range of 01/01/1900 to 31/12/2002 inclusive and it accepts input such as 1/1/1900 instead of forcing the user to type 01/01/1900 to be accepted
• Enhanced field Department: It will now accept only 2 to 30 characters
• Enhanced field `Position: It will now accept only 2 to 30 characters
• Fixed bug whereby overloaded prefix is allowed in filter command
• Fixed bug whereby the sort argument in filter command is affected by case
• Fixed bug whereby duplicate listing of department and position appears when filter command shows 0 person listed
• Fixed bug whereby filtering by descending order causes list to also show every employee in the system in descending name order
• Minor updates to GUI overall appearance and fields within PersonCard

---

Milestone 2
v1.2

• New command filter: Allows filtering of employees by their Department or Position fields individually
• Enhanced command filter: Allows filtering of employees by their Department and Position fields
• Fixed bug where filter command throws exception when d/ or r/ is typed without any characters following after the prefix
• Added test files for filter command

---

Milestone 1
v1.1

• New fields, namely EmployeeId, DateOfBirth Department, Position, Salary and Bonus, have been added
• Enhanced command add: Compulsory fields added to the command EmployeeId, DateOfBirth, Department, Position and Salary and their prefixes are id/, dob/, d/, r/ and s/
• Enhanced command edit: Editing of Department and Position field are now available with theirr prefix d/ and r/ respectively

[coveralls]

Pull Request Test Coverage Report for Build 914

• 81 of 128 (63.28%) changed or added relevant lines in 15 files are covered.
• 5 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.2%) to 54.225%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/main/java/seedu/address/logic/parser/AddCommandParser.java	21	22	95.45%
src/main/java/seedu/address/model/expenses/UniqueExpensesList.java	3	4	75.0%
src/main/java/seedu/address/model/ModelManager.java	8	12	66.67%
src/main/java/seedu/address/logic/parser/FilterCommandParser.java	0	41	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/main/java/seedu/address/model/addressbook/DayHourGreeting.java	2	53.85%
src/main/java/seedu/address/logic/parser/FilterCommandParser.java	3	0.0%

Totals
Change from base Build 896:	0.2%
Covered Lines:	2612
Relevant Lines:	4817

---

💛 - Coveralls

[ChuaZhenWei]

very good