Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Test filesV1.4.4 #243

Merged
merged 14 commits into from Nov 11, 2018
Merged

Update Test filesV1.4.4 #243

merged 14 commits into from Nov 11, 2018

Conversation

ryanchen2018
Copy link
Collaborator

@ryanchen2018 ryanchen2018 commented Nov 11, 2018 •
edited

  • Add PostContainsKeywordsPredicateTest
  • Add RecruitmentTest
  • Add RecruitmentListTest
  • Add RecruitmentListBuilder
  • Add VersionedRecruitmentListTest
  • Add UniqueRecruitmentListTest

@ryanchen2018 ryanchen2018 self-assigned this Nov 11, 2018
@ryanchen2018 ryanchen2018 added status.ongoing The issue is currently being worked on. note: remove this label before closing an issue. priority.high Must do update.testcase Test Cases Update v1.4 v1.4 Milestone labels Nov 11, 2018
@coveralls
Copy link

coveralls commented Nov 11, 2018 •
edited

Pull Request Test Coverage Report for Build 1238

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 54 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.8%) to 88.709%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/logic/commands/AddExpensesCommand.java 54 6.7%
Totals Coverage Status
Change from base Build 1180: 3.8%
Covered Lines: 4337
Relevant Lines: 4889
💛 - Coveralls

@LimYiSheng LimYiSheng self-requested a review November 11, 2018 12:14
LimYiSheng
LimYiSheng approved these changes Nov 11, 2018
View reviewed changes
Copy link
Collaborator

@LimYiSheng LimYiSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@LimYiSheng LimYiSheng merged commit 4ff1b2a into CS2113-AY1819S1-T16-4:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimYiSheng LimYiSheng LimYiSheng approved these changes

Assignees

@ryanchen2018 ryanchen2018

Labels
priority.high Must do status.ongoing The issue is currently being worked on. note: remove this label before closing an issue. update.testcase Test Cases Update v1.4 v1.4 Milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanchen2018 @coveralls @LimYiSheng