Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated portfolio and test case #246

Merged
merged 4 commits into from Nov 11, 2018
Merged

Updated portfolio and test case #246

merged 4 commits into from Nov 11, 2018

Conversation

ChuaZhenWei
Copy link
Collaborator

changing of standardcommand==null to standardcommand.equals(null) to increase coverage.
updated portfolio

@ChuaZhenWei ChuaZhenWei self-assigned this Nov 11, 2018
@ChuaZhenWei ChuaZhenWei added update.documentation Documentation Update update.testcase Test Cases Update v1.4 v1.4 Milestone priority.high Must do labels Nov 11, 2018
@ChuaZhenWei ChuaZhenWei added this to the v1.4 milestone Nov 11, 2018
@coveralls
Copy link

coveralls commented Nov 11, 2018 •
edited

Pull Request Test Coverage Report for Build 1212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 54 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.008%) to 87.871%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/logic/commands/AddExpensesCommand.java 54 6.7%
Totals Coverage Status
Change from base Build 1180: 3.008%
Covered Lines: 4296
Relevant Lines: 4889
💛 - Coveralls

LimYiSheng
LimYiSheng approved these changes Nov 11, 2018
View reviewed changes
Copy link
Collaborator

@LimYiSheng LimYiSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved

@LimYiSheng LimYiSheng merged commit b4b66ac into CS2113-AY1819S1-T16-4:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimYiSheng LimYiSheng LimYiSheng approved these changes

Assignees

@ChuaZhenWei ChuaZhenWei

Labels
priority.high Must do update.documentation Documentation Update update.testcase Test Cases Update v1.4 v1.4 Milestone
Projects
No open projects
Centralized Human Resource System (CHRS)
  
Awaiting triage
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChuaZhenWei @coveralls @LimYiSheng