Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.2.1 Schedule Feature #69

Merged
merged 27 commits into from Oct 10, 2018
Merged

V1.2.1 Schedule Feature #69

merged 27 commits into from Oct 10, 2018

Conversation

zhihong8888
Copy link
Collaborator

@zhihong8888 zhihong8888 commented Oct 10, 2018 •
edited

V1.2.1 Schedule Command Fixing #66 issue.

  • Schedule list user interface
  • Check Employee Id exists, before allowing the user to add a new schedule with the specified employee id.
  • Improved Date model and Type model regular expression check.
  • Test case updated

@zhihong8888 zhihong8888 self-assigned this Oct 10, 2018
@zhihong8888 zhihong8888 added type.story A user story type.enhancement An enhancement to an existing story priority.high Must do labels Oct 10, 2018
@zhihong8888 zhihong8888 changed the title Schedule Feature V1.2.1 branch Schedule Feature V1.2.1 Branch Oct 10, 2018
@zhihong8888 zhihong8888 added this to the v1.2 milestone Oct 10, 2018
@coveralls
Copy link

coveralls commented Oct 10, 2018 •
edited

Pull Request Test Coverage Report for Build 262

  • 25 of 136 (18.38%) changed or added relevant lines in 19 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.0%) to 68.892%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/ParserUtil.java 0 1 0.0%
src/main/java/seedu/address/model/schedule/exceptions/ScheduleNotFoundException.java 0 1 0.0%
src/main/java/seedu/address/ui/MainWindow.java 2 3 66.67%
src/main/java/seedu/address/model/ModelManager.java 0 2 0.0%
src/main/java/seedu/address/model/addressbook/AddressBook.java 0 2 0.0%
src/main/java/seedu/address/model/person/UniquePersonList.java 0 2 0.0%
src/main/java/seedu/address/model/schedule/exceptions/DuplicateScheduleException.java 0 2 0.0%
src/main/java/seedu/address/logic/commands/AddScheduleCommand.java 0 3 0.0%
src/main/java/seedu/address/storage/schedule/XmlAdaptedSchedule.java 0 3 0.0%
src/main/java/seedu/address/model/schedule/Schedule.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/model/schedule/Date.java 1 0.0%
src/main/java/seedu/address/logic/commands/AddScheduleCommand.java 1 0.0%
Totals Coverage Status
Change from base Build 237: -2.0%
Covered Lines: 1734
Relevant Lines: 2517
💛 - Coveralls

LimYiSheng
LimYiSheng reviewed Oct 10, 2018
View reviewed changes
src/main/java/seedu/address/model/person/Person.java
/**
* Returns true if both persons of the same name have at least one other identity field that is the same.
* This defines a weaker notion of equality between two persons.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do edit the comment above, i guess it's supposed to be both persons of the same employeeId

LimYiSheng
LimYiSheng approved these changes Oct 10, 2018
View reviewed changes
Copy link
Collaborator

@LimYiSheng LimYiSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved, @XiiaoPanda do proceed to merge after your check. Ensure that Travis-CI and Appveyor are successful.

@XiiaoPanda
Copy link
Collaborator

Command and UI work beautifully.

XiiaoPanda
XiiaoPanda approved these changes Oct 10, 2018
View reviewed changes
Copy link
Collaborator

@XiiaoPanda XiiaoPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command and UI work beautifully. Dates for February and leap year was also taken care of.

@XiiaoPanda XiiaoPanda merged commit 89587b3 into CS2113-AY1819S1-T16-4:master Oct 10, 2018
@zhihong8888 zhihong8888 changed the title Schedule Feature V1.2.1 Branch V1.2.1 Schedule Feature Oct 14, 2018
@LimYiSheng LimYiSheng added the v1.2 v1.2 Milestone label Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiiaoPanda XiiaoPanda XiiaoPanda approved these changes

@LimYiSheng LimYiSheng LimYiSheng approved these changes

Assignees

@zhihong8888 zhihong8888

Labels
priority.high Must do type.enhancement An enhancement to an existing story type.story A user story v1.2 v1.2 Milestone
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhihong8888 @coveralls @XiiaoPanda @LimYiSheng