Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change browsePanel content #120

Merged
merged 3 commits into from Oct 30, 2018

Conversation

linnnruoo
Copy link

image

this is the current look. If our theme shifts towards delivery services, the browsepanel content will make some sort of sense

@linnnruoo linnnruoo self-assigned this Oct 29, 2018
@linnnruoo
Copy link
Author

@jitwei98 wah it failed at the browsepanel, should i remove its associated tests?

@linnnruoo
Copy link
Author

linnnruoo commented Oct 29, 2018

image

Revert back to this one as the one with google map fails some of the system tests
Propose: remove some of the system tests for browserPanel or completely remove this section

@jitwei98
Copy link
Collaborator

Should I merge this?

Copy link
Collaborator

@jitwei98 jitwei98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please help to update the Ui.png in README.adoc too.
Thanks!

@linnnruoo
Copy link
Author

@jitwei98 it will be updated automatically once the binary file has been changed

@jitwei98
Copy link
Collaborator

@linnnruoo ok noted!

@jitwei98 jitwei98 merged commit bc268ed into CS2113-AY1819S1-W12-1:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants