Set a minimum to window size (#138)

Set a minimum to window size
CS2113-AY1819S1-W12-3 · Nov 1, 2018 · b59cf9a · b59cf9a
2 parents d358aba + 7b56404
commit b59cf9a
Show file tree

Hide file tree

Showing 5 changed files with 113 additions and 33 deletions.
diff --git a/docs/AboutUs.adoc b/docs/AboutUs.adoc
@@ -38,15 +38,15 @@ Responsibilities: Documentation
 
 === Low Gin Wee
 image::LowGinWee.png[width="150", align="left"]
-{empty}[https://github.com/LowGinWee[github]]
+{empty}[https://github.com/LowGinWee[github]][<<LowGinWee#, portfolio>>]
 
 Role: Developer +
 Responsibilities: Deliverables and deadline
 
 '''
 === Ler Wei Sheng
 image::lws803.png[width="150", align="left"]
-{empty}[https://github.com/lws803[github]]
+{empty}[https://github.com/lws803[github]][<<lws803#, portfolio>>]
 
 Role: Developer +
 Responsibilities: Testing, Integration

diff --git a/docs/team/LowGinWee.adoc b/docs/team/LowGinWee.adoc
@@ -0,0 +1,86 @@
+= Low Gin Wee - Project Portfolio
+:site-section: AboutUs
+:imagesDir: ../images
+:stylesDir: ../stylesheets
+
+== PROJECT: CorpPro
+
+---
+
+== Overview
+
+*CorpPro* is a desktop address book application which targets Corporate Users. It strives to help its users better manage
+their information to increase efficiency and to produce effective results. *CorpPro*’s features aid users to find relevant
+details quickly, in addition to being able to create a schedule to plan and set goals. Users can create and update entries
+in *CorpPro* through the command-line interface(CLI), as well as having an uncluttered user interface(UI) to display corresponding
+information. It is made using Java, a widely used programming language, with over 10 thousand lines written.
+
+== Summary of contributions
+
+* *Major enhancement*: Added *additional attributes* to each contact in the address book
+** What it does: The following attributes have been added:
+     *** Position/rank
+     *** Tag priority
+     *** Key Performance Index(KPI)
+     *** Note/Description
+** Justification: As a corporate user with many contacts, there is a need to tag or describe each contact to recognise or
+find them quickly. Tags now have priorities to better indicate the importance of each contact. The Key Performing Index (KPI)
+is also included in the attributes to better facilitate managers or supervisors in rating or ranking their employees.
+** Highlights: This feature affects existing commands and facilitates listing or finding contacts via these additional attributes.
+
+* *Major enhancement*: *Added schedule*
+** What it does: Users are able to create activities or tasks and add them to their schedule in *CorpPro*. These activities
+are sorted by date and can be edited or deleted when completed. The schedule is also saved when the user closes the application
+** Justification: Corporate users may need to organise their assignments in a schedule to maintain a methodical workstyle
+to increase efficiency and not to neglect any important tasks.
+** Highlights: This feature required the creation of additional commands and the implementation of exporting the schedule to save
+its contents after the user has exit the application.In addition, a unique data structure had to be used to maintain a sorted schedule(by date).
+
+* *Minor enhancement*: Enhanced the edit command to edit all listed entries in one command.
+
+* *Code contributed*: [https://github.com[Functional code]] [https://github.com[Test code]] _{give links to collated code files}_
+
+* *Other contributions*:
+
+** Project management:
+
+** Enhancements to existing features:
+**** Updated the colour scheme(Pull Requests:)
+**** Cosmetic tweaks of UI
+**** Information panel
+**** Labels
+**** Schedule Panel
+**** Icon
+
+** Community:
+*** PRs reviewed (with non-trivial review comments):
+*** Contributed to forum discussions (examples: )
+*** Created meeting minutes during each team meeting (examples: )
+
+== Contributions to the User Guide
+
+
+|===
+|_Given below are sections I contributed to the User Guide. They showcase my ability to write documentation targeting end-users._
+|===
+
+include::../UserGuide.adoc[tag=undoredo]
+
+include::../UserGuide.adoc[tag=dataencryption]
+
+== Contributions to the Developer Guide
+
+|===
+|_Given below are sections I contributed to the Developer Guide. They showcase my ability to write technical documentation and the technical depth of my contributions to the project._
+|===
+
+include::../DeveloperGuide.adoc[tag=undoredo]
+
+include::../DeveloperGuide.adoc[tag=dataencryption]
+
+
+== PROJECT: PowerPointLabs
+
+---
+
+_{Optionally, you may include other projects in your portfolio.}_
diff --git a/src/main/resources/view/BrowserPanel.fxml b/src/main/resources/view/BrowserPanel.fxml
@@ -12,7 +12,7 @@
 <?import javafx.scene.layout.VBox?>
 <?import javafx.scene.web.WebView?>
 
-<StackPane xmlns="http://javafx.com/javafx/8.0.171" xmlns:fx="http://javafx.com/fxml/1">
+<StackPane minWidth="300.0" xmlns="http://javafx.com/javafx/8.0.171" xmlns:fx="http://javafx.com/fxml/1">
    <children>
       <WebView fx:id="browser" opacity="0.0" prefHeight="200.0" prefWidth="200.0" />
       <VBox fx:id="display" prefHeight="500.0" prefWidth="600.0" spacing="5.0">

diff --git a/src/main/resources/view/MainWindow.fxml b/src/main/resources/view/MainWindow.fxml
@@ -10,9 +10,9 @@
 <?import javafx.scene.image.Image?>
 <?import javafx.scene.layout.StackPane?>
 <?import javafx.scene.layout.VBox?>
+<?import javafx.stage.Stage?>
 
-<fx:root type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/8" xmlns:fx="http://javafx.com/fxml/1"
-         minWidth="450" minHeight="600" onCloseRequest="#handleExit">
+<fx:root maximized="true" minHeight="800.0" minWidth="1000.0" onCloseRequest="#handleExit" type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/8.0.171" xmlns:fx="http://javafx.com/fxml/1">
   <icons>
     <Image url="@/images/address_book_32.png" />
   </icons>
@@ -33,35 +33,34 @@
           </Menu>
         </MenuBar>
 
-        <StackPane VBox.vgrow="NEVER" fx:id="commandBoxPlaceholder" styleClass="pane-with-border">
+        <StackPane fx:id="commandBoxPlaceholder" styleClass="pane-with-border" VBox.vgrow="NEVER">
           <padding>
-            <Insets top="5" right="10" bottom="5" left="10" />
+            <Insets bottom="5" left="10" right="10" top="5" />
           </padding>
         </StackPane>
 
-        <StackPane VBox.vgrow="NEVER" fx:id="resultDisplayPlaceholder" styleClass="pane-with-border"
-                   minHeight="145" prefHeight="145" maxHeight="145">
+        <StackPane fx:id="resultDisplayPlaceholder" maxHeight="145" minHeight="145" prefHeight="145" styleClass="pane-with-border" VBox.vgrow="NEVER">
           <padding>
-            <Insets top="5" right="10" bottom="5" left="10" />
+            <Insets bottom="5" left="10" right="10" top="5" />
           </padding>
         </StackPane>
 
-        <SplitPane id="splitPane" fx:id="splitPane" dividerPositions="0.4" VBox.vgrow="ALWAYS">
+        <SplitPane id="splitPane" fx:id="splitPane" dividerPositions="0.4, 0.5" VBox.vgrow="ALWAYS">
           <VBox fx:id="personList" minWidth="340" prefWidth="340" SplitPane.resizableWithParent="false">
             <padding>
-              <Insets top="10" right="10" bottom="10" left="10" />
+              <Insets bottom="10" left="10" right="10" top="10" />
             </padding>
-            <StackPane fx:id="personListPanelPlaceholder" VBox.vgrow="ALWAYS"/>
+            <StackPane fx:id="personListPanelPlaceholder" VBox.vgrow="ALWAYS" />
           </VBox>
 
-          <StackPane fx:id="browserPlaceholder" prefWidth="340" >
+          <StackPane fx:id="browserPlaceholder" prefWidth="340">
             <padding>
-              <Insets top="10" right="10" bottom="10" left="10" />
+              <Insets bottom="10" left="10" right="10" top="10" />
             </padding>
           </StackPane>
-          <StackPane fx:id="schedulePlaceholder" prefWidth="340" >
+          <StackPane fx:id="schedulePlaceholder" prefWidth="340">
             <padding>
-              <Insets top="10" right="10" bottom="10" left="10" />
+              <Insets bottom="10" left="10" right="10" top="10" />
             </padding>
           </StackPane>
         </SplitPane>

diff --git a/src/main/resources/view/SchedulePanel.fxml b/src/main/resources/view/SchedulePanel.fxml
@@ -4,23 +4,18 @@
 <?import javafx.scene.control.Label?>
 <?import javafx.scene.control.ScrollPane?>
 <?import javafx.scene.layout.AnchorPane?>
-<?import javafx.scene.layout.StackPane?>
 <?import javafx.scene.layout.VBox?>
 
-<StackPane xmlns="http://javafx.com/javafx/8.0.171" xmlns:fx="http://javafx.com/fxml/1">
+<VBox fx:id="schedulePanel" minHeight="300.0" minWidth="300.0" prefHeight="300.0" prefWidth="300.0" style="-fx-background-color: white; -fx-background-radius: 5 5 5 5; -fx-border-radius: 5 5 5 5;" xmlns="http://javafx.com/javafx/8.0.171" xmlns:fx="http://javafx.com/fxml/1">
    <children>
-      <VBox fx:id="schedulePanel" style="-fx-background-color: white; -fx-background-radius: 5 5 5 5; -fx-border-radius: 5 5 5 5;">
-         <children>
-            <Label prefHeight="17.0" prefWidth="111.0" text=" Schedule" />
-            <ScrollPane fx:id="scrollPane" fitToHeight="true" fitToWidth="true" style="-fx-background-color: white;">
-              <content>
-                <AnchorPane minHeight="0.0" minWidth="0.0" style="-fx-background-color: white;" />
-              </content>
-            </ScrollPane>
-         </children>
-         <opaqueInsets>
-            <Insets left="10.0" top="5.0" />
-         </opaqueInsets>
-      </VBox>
+      <Label prefHeight="17.0" prefWidth="111.0" text=" Schedule" />
+      <ScrollPane fx:id="scrollPane" fitToHeight="true" fitToWidth="true" minWidth="300.0" prefWidth="300.0" style="-fx-background-color: white;">
+         <content>
+            <AnchorPane minHeight="0.0" minWidth="0.0" style="-fx-background-color: white;" />
+         </content>
+      </ScrollPane>
    </children>
-</StackPane>
+   <opaqueInsets>
+      <Insets left="10.0" top="5.0" />
+   </opaqueInsets>
+</VBox>