Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit command allows 2 same persons to exist #153

Closed
nus-pe-script opened this issue Nov 2, 2018 · 0 comments
Closed

Edit command allows 2 same persons to exist #153

nus-pe-script opened this issue Nov 2, 2018 · 0 comments
Assignees

Comments

@nus-pe-script
Copy link

Describe the bug
Editing the individual attributes email, phone and address will allow 2 persons with the exact same details to exist.
image

To Reproduce
Steps to reproduce the behavior:

  1. Add these 2 persons in the list
    image

  2. Run
    edit 2 p/1234
    edit 2 a/test
    edit 2 p/fds@gmail.com

  3. See error

Expected behavior
I expect the edits to be disallowed.

Additional context
When adding 2 persons with the exact same details is not allowed. So I presume that 2 persons with the exact same details is not allowed by design. However, I can edit 2 persons to have the exact same details.


Reported by: @wm28
Severity: High

[original: nusCS2113-AY1819S1/pe-1#646]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants