Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beefed up Developer guide and changed some of the implementations #158

Merged
merged 75 commits into from Nov 5, 2018
Merged

Beefed up Developer guide and changed some of the implementations #158

merged 75 commits into from Nov 5, 2018

Conversation

Limminghong
Copy link

  • restore snapshots is now restore-snapshots
  • CsvWriter is now split to CsvReader and CsvWriter
  • Added implementation for my features in the developer guide.

@Limminghong
Coded the export feature
fa32ffd 
It takes in a directory and a name and exports the xml file to the location
Directory and name willbe that of default if not specified
Currently does not converts to .csv file
@Limminghong
Updated user guide: changed the command format for export
cb6282e
@Limminghong
Implemented the import feature, currently replaces the whole addressb…
702c09b 
…ook.xml file
@Limminghong
Implemented xml to csv converter. Export function now saves file in .…
149a31f 
…csv format

Bug: since some addresses have commas, they do not show up correctly in .csv file
@Limminghong
Updated ".gitignore"
e749ea8
@Limminghong
Fixed Travis errors
a32bbb5
@Limminghong
Added quotation marks to encapsulate every string to fix bug on comma…
01be207 
…s interfering with the excel file.

moved style.xsl to resource/view
Updated .gitignore
@Limminghong
Fixed Travis errors
a92913a
@Limminghong
Changed prefix names for export and import
956bf3c 
Updated user guide prefixes
@Limminghong
Added the implementation for backup and listing of snapshots in the u…
8ee820f 
…ser guide
@Limminghong
Resolved merge conflict
f8c5ccc
@Limminghong
Edited "f" to "f/"
ab815ea
@Limminghong
Reimplemented the export feature, CsvParser writes UniquePersonsList …
1850906 
…to a .csv file
@Limminghong
Fixed Travis errors
877455c
@Limminghong
Renamed CsvParser to CsvWriter
0c249bc
@Limminghong
Fixed Travis Errors
594ab3c
@Limminghong
Added conversion of File type to List<Person> in CsvWriter
178171c
@Limminghong
Import is now fully implemented. It appends the addressbook with the …
7d4d0ae 
…imported data.

Bug (Major): if .csv file is edited in excel, format of the whole file will change, thus rendering the CsvWrite useless
@Limminghong
Fixed AppVeyor errors
ed9a4e6
@Limminghong
Fixed AppVeyor errors
3ec5680
@Limminghong
Merge remote-tracking branch 'upstream/master'
50caef0 
It is necessary
@Limminghong
Added .trim() to ExportCommand
8ea02af 
Abstracted makeBackup
Made fileName accessible to testcases
@Limminghong
Added JavaDoc for getFileName
d874679
@Limminghong
Fixed AppVeyor error
55fb5da
@Limminghong
Added deletion of backup snapshot after backup command has ran
dd50e76
@Limminghong
Fixed error by introducing stubs
8e8535c
@Limminghong
Added JavaDoc to fix some errors
a8abd24
@Limminghong
Catch IOException in line 41 of BackUpCommandTest
f259638
@Limminghong
Overload BackUpCommand() to accept a source directory
6df22fd
@Limminghong
Reimplemented backup and restore
b93eb63 
does not touch addressbook.xml
@Limminghong
Fixed errors
89c2e9a
@Limminghong
Merge remote-tracking branch 'upstream/master'
0c3ffab 
Dont understand this
@Limminghong
Fixed checkstyle error
55dfd8a
@Limminghong
Fixed errors by ignoring test
7eba402
@Limminghong
Merge remote-tracking branch 'upstream/master'
e2ec656 
What is this
@Limminghong
Updated Restore command in user guide
6f4a7fb
@Limminghong
Updated backup in user guide
f72713c
@Limminghong
Updated import command in user guide
aa65dfd
@Limminghong
Updated import command in user guide
6ff1e18
@Limminghong
Updated user stories in DeveloperGuide
74d1226
@Limminghong
Included Appendix A which explains the format of the exported CSV file
33a932c
@Limminghong
Beefed up FAQ
a1aa07c
@Limminghong
Remove Restore implementation for now to make developer guide look nice
5186dcb
@Limminghong
Added new line at EOF for User Guide :/
e26c88e
@Limminghong
Added Limminghong.adoc
02264d6
@Limminghong
Changed all "\\" to File.separator
34aeb74
@Limminghong
Removed the ======
b983d9a
@Limminghong
Merge remote-tracking branch 'upstream/master'
f914246 
Help me
@Limminghong
Merge remote-tracking branch 'upstream/master'
84e54a5 
What is this yo
@Limminghong
Beefed up implementation for backup and restore
086ecd1
@Limminghong
Added implementation for Export
d23c0f6
@Limminghong
1. Separated CsvWriter and CsvReader
ea4a1b1 
2. changed restore snapshots to restore-snapshots
@Limminghong
Beefed up import and export implementation in Developers guide
d2be170
@Limminghong
Added my contributions to the developer guide into my PPP
4ad0540
@Limminghong
Fixed RestoreCommandTest
c8c9b7b
@Limminghong Limminghong self-assigned this Nov 4, 2018
@Limminghong Limminghong added the type.enhancement New feature or request label Nov 4, 2018
@Limminghong Limminghong added this to the v1.4 milestone Nov 4, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 482

  • 12 of 104 (11.54%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.8%) to 87.034%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/seedu/address/logic/parser/AddressBookParser.java 0 1 0.0%
src/main/java/seedu/address/model/backup/BackupList.java 12 14 85.71%
src/main/java/seedu/address/logic/commands/ImportCommand.java 0 3 0.0%
src/main/java/seedu/address/logic/parser/RestoreCommandParser.java 0 3 0.0%
src/main/java/seedu/address/logic/commands/RestoreSnapshotsCommand.java 0 17 0.0%
src/main/java/seedu/address/storage/CsvReader.java 0 66 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/seedu/address/logic/commands/RestoreSnapshotsCommand.java 1 0.0%
src/main/java/seedu/address/model/backup/BackupList.java 1 88.46%
src/main/java/seedu/address/logic/commands/ImportCommand.java 2 8.7%
Totals Coverage Status
Change from base Build 481: 0.8%
Covered Lines: 2987
Relevant Lines: 3432
💛 - Coveralls

@Limminghong Limminghong merged commit ed19984 into CS2113-AY1819S1-W12-3:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Limminghong Limminghong

Labels
type.enhancement New feature or request
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Limminghong @coveralls