Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Note object. Added Edit All function. Added UniqueTagList to store existing tags and associated persons #79

Merged
merged 7 commits into from Oct 11, 2018

Conversation

LowGinWee
Copy link

@LowGinWee LowGinWee commented Oct 10, 2018

Note object now does not show up in UI if user does not specify it.
Edit All function to edit all listed persons by using the argument "all/"

TODO:
To update edit command description and user disclaimer
To update persons displayed to only those who are edited
To merge and to edit/update trie as per add, delete or edit via checking the UniqueTagList
To update description of methods in UniqueTagLIst.java

To update UGDG

Note does not show if none is specified
Edit All function works when editing all but not for when editing only
those listed
To show warning if name is changed
To show UI of only those edited
@LowGinWee LowGinWee modified the milestones: v1.3, v1.2 Oct 10, 2018
@LowGinWee LowGinWee added type.enhancement New feature or request status.ongoing The issue is currently being worked on. note: remove this label before closing an issue. labels Oct 10, 2018
@LowGinWee
Copy link
Author

To xavier:
The addition of the UniqueTagList is in the following files:
Addressbook.java - the instance of UniqueTagList is created here
UniqueTagList.java

@LowGinWee LowGinWee changed the title Updated Note objects. Added Edit All function. Added UniqueTagList to store existing tags and associated persons Updated Note object. Added Edit All function. Added UniqueTagList to store existing tags and associated persons Oct 10, 2018
@lekoook
Copy link

lekoook commented Oct 10, 2018

@LowGinWee >
I think the UniqueTagList should map the key (Tag) to a List/ArrayList< Persons >. This will cut down the memory overhead of using UniquPersonList as well as reduce coupling between the two.
Also, I think there should be methods to add/remove/edit single Tags instead of adding ALL tags from a single person. I think this gives better flexibility to use your class.

@LowGinWee LowGinWee merged commit b00e3b0 into CS2113-AY1819S1-W12-3:master Oct 11, 2018
@LowGinWee LowGinWee removed the status.ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 11, 2018
@LowGinWee LowGinWee self-assigned this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants