Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select command #109

Merged
merged 3 commits into from Nov 4, 2018
Merged

Fix select command #109

merged 3 commits into from Nov 4, 2018

Conversation

nianfei97
Copy link

@nianfei97 nianfei97 commented Nov 2, 2018 •
edited

  • Command to select yourself is now select me instead of select
  • Command now prints name of person selected instead of index

Closes #101

@nianfei97 nianfei97 added this to the v1.4 milestone Nov 2, 2018
@nianfei97 nianfei97 added type.bug A bug priority.medium Nice to have status.complete The pull request is ready to be merged labels Nov 2, 2018
alexiscatnip
alexiscatnip approved these changes Nov 4, 2018
View reviewed changes
Copy link

@alexiscatnip alexiscatnip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on implementing this usability feature! I like how your test is called execute_me_success! 👍

@alexiscatnip alexiscatnip merged commit b668685 into CS2113-AY1819S1-W13-1:master Nov 4, 2018
@nianfei97 nianfei97 deleted the select branch November 6, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexiscatnip alexiscatnip alexiscatnip approved these changes

Assignees
No one assigned
Labels
priority.medium Nice to have status.complete The pull request is ready to be merged type.bug A bug
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nianfei97 @alexiscatnip