Added more sample data #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nianfei97
added
type.task
|
Looks great, but the data is not changed for the new |
cjinting-nus
approved these changes
Nov 11, 2018
| @@ -10,7 +10,7 @@ | |||
| public class Tag { | |||
|
|
|||
| public static final String MESSAGE_CONSTRAINTS = "Tags names should be alphanumeric"; | |||
| public static final String VALIDATION_REGEX = "\\p{Alnum}+"; | |||
| public static final String VALIDATION_REGEX = ".+"; | |||
There was a problem hiding this comment.
Why the change to accept all characters though
There was a problem hiding this comment.
I guess just so that I can have dashes in my group names lol
There was a problem hiding this comment.
Because one of your invalid tags in your sample data was friend* but that's true I'll added dashes and underscores in but no special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.