Timetable import and export feature #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elp us parse .ics files.
… work. Instructions on biweekly's git not clear for noob. Not sure what I am doing here. Not enough handholding.
…so Created function for export in IcsUtil. Also created additional functions in TimeSlot and TimeTable classes to get some of their data easily.
-Can now export the timetable, but the format of the exported .ics file is incomplete and broken! :(
Export function now works, and can be imported back it after being exported! :D
nianfei97
previously approved these changes
Oct 23, 2018
| * 2) Also used during import and export commands (ie, read and write) | ||
| * | ||
| * NOTE: Only support ICS to-and-from TimeTable Objects(!!). | ||
| * TODO: allow conversion to objects other than timetable |
There was a problem hiding this comment.
Hmm I don't think there's a need to convert anything else to .ics format...
What other things were you thinking about?
| * | ||
| * NOTE: Only support ICS to-and-from TimeTable Objects(!!). | ||
| * TODO: allow conversion to objects other than timetable | ||
| * TODO: create a 'serialisable' class to serialise(?) the timetable objects to ics file formats |
There was a problem hiding this comment.
I don't think "serializable" actually has any special meaning lol, so I don't think this is necessary
| private static IcsUtil instance; | ||
|
|
||
| private IcsUtil(){ | ||
| //any things to initialise? |
| LocalTime timeSlotEndTime = timeStringToLocalTime(timeEndStr); | ||
| DayOfWeek timeSlotDay = dateStringToDayOfWeek(dateStartStr); | ||
|
|
||
| System.out.println(timeSlotStartTime + " to " + timeSlotEndTime + " on " + timeSlotDay + ": " + summaryStr); |
nianfei97
added
type.story
2 tasks
nianfei97
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I changed build.gradle to have an extra dependency: biweekly. This has not been reflected in UG/DG/docs yet.