Free command #64
Merged
Free command #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nianfei97
added
type.story
nianfei97
force-pushed
the
v1.3
branch
2 times, most recently
from
4f427fa
to
f78a8fb
Compare
nianfei97
added
status.complete
bennchong
reviewed
Oct 27, 2018
| } | ||
|
|
||
| @Test | ||
| public void equals() { |
There was a problem hiding this comment.
I think having many small individual test is better than having one big test, do lookup @before and @BeforeClass if your small tests requires certain setup
There was a problem hiding this comment.
Fair point, but I basically just copied the equals test from the other commands like EditCommandTest lol
|
Closes #26 |
nianfei97
added
status.ongoing
|
Back to ongoing while I integrate with the new |
nianfei97
added
status.complete
|
Ready to merge |
|
Looks good |
bennchong
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freebackend and testsfreefrontend and tests (executetests deferred until Adding "Me" Panel to display self + FriendFeature #56 is merged)freegraphics (make it look different from normal timetables)indexfromaddtimeanddeletetimeNote:
Integration with
selectcommand is scrapped due to time constraints. To usefree, users must inputfree [INDICES].