-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"edit" command allows ending time to be earlier than starting time (and times with invalid format) #100
Comments
Same as #61 !! @cjunxiang |
resolved |
still buggy... |
that's cause the PR havent got accepted heh |
ps. PR #119 didn't solve this - so reopened this, to remind myself when I'm testing for bugs in the later release (hopefully tmr night? :P) |
add ds/07112018 ts/0792 de/07112018 te/1000 ss/0900 d/10 pg/A l/Sentosa tz/+8 ts of 0792 is not a valid time! @cjunxiang bro this is still buggy XD ps. closing issues should be done after the PR is merged to see if the bug is fixed... |
haha well if it takes 5 days to get a PR reviewed i figure i might as well close it to track my own progress. |
Seems fixed finally! |
Describe the bug
When I entered the command "edit 1 te/0670" (a nonsense time format which is also earlier than the starting time), the update is successful.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Program should prevent nonsense updates/entries.
Screenshots
![image](https://user-images.githubusercontent.com/35793358/47908442-317e8200-dec8-11e8-9e7a-1d5507cb9f34.png)
Reported by: @ongweekeong
Severity:
Low
[original: nusCS2113-AY1819S1/pe-1#610]
The text was updated successfully, but these errors were encountered: