Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"edit" command allows ending time to be earlier than starting time (and times with invalid format) #100

Closed
nus-pe-script opened this issue Nov 2, 2018 · 8 comments
Assignees
Labels
Milestone

Comments

@nus-pe-script
Copy link

Describe the bug
When I entered the command "edit 1 te/0670" (a nonsense time format which is also earlier than the starting time), the update is successful.

To Reproduce
Steps to reproduce the behavior:

  1. Go to input textbox.
  2. Type "edit 1 te/0670".
  3. Press enter.
  4. Click on entry Updated the about us, changed storage and package name #1.
  5. See error.

Expected behavior
Program should prevent nonsense updates/entries.

Screenshots
image


Reported by: @ongweekeong
Severity: Low

[original: nusCS2113-AY1819S1/pe-1#610]

@arjo129
Copy link

arjo129 commented Nov 3, 2018

Same as #61 !! @cjunxiang

@arjo129 arjo129 added duplicate This issue or pull request already exists type.bug A bug priority.high Must do labels Nov 3, 2018
arjo129 added a commit that referenced this issue Nov 7, 2018
Added Extra Conditions to ensure #104 #100
@cjunxiang
Copy link

resolved

@shuanang
Copy link

shuanang commented Nov 7, 2018

still buggy...

@shuanang shuanang reopened this Nov 7, 2018
@cjunxiang
Copy link

that's cause the PR havent got accepted heh

@shuanang
Copy link

shuanang commented Nov 9, 2018

ps. PR #119 didn't solve this - so reopened this, to remind myself when I'm testing for bugs in the later release (hopefully tmr night? :P)

@shuanang shuanang reopened this Nov 9, 2018
@shuanang
Copy link

shuanang commented Nov 9, 2018

add ds/07112018 ts/0792 de/07112018 te/1000 ss/0900 d/10 pg/A l/Sentosa tz/+8

ts of 0792 is not a valid time!

@cjunxiang bro this is still buggy XD ps. closing issues should be done after the PR is merged to see if the bug is fixed...

@arjo129 arjo129 changed the title "edit" command allows ending time to be earlier than starting time "edit" command allows ending time to be earlier than starting time (and times with invalid format) Nov 10, 2018
@arjo129 arjo129 added this to the v1.4 milestone Nov 10, 2018
@arjo129 arjo129 removed the duplicate This issue or pull request already exists label Nov 10, 2018
@cjunxiang
Copy link

add ds/07112018 ts/0792 de/07112018 te/1000 ss/0900 d/10 pg/A l/Sentosa tz/+8

ts of 0792 is not a valid time!

@cjunxiang bro this is still buggy XD ps. closing issues should be done after the PR is merged to see if the bug is fixed...

haha well if it takes 5 days to get a PR reviewed i figure i might as well close it to track my own progress.
anyway i done up a new PR! Thanks for helping to review

@cjunxiang cjunxiang mentioned this issue Nov 10, 2018
@arjo129
Copy link

arjo129 commented Nov 10, 2018

Seems fixed finally!

@arjo129 arjo129 closed this as completed Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants