Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on week 7 project progress #12

Open
15 of 27 tasks
nus-pe-script opened this issue Oct 2, 2018 · 1 comment
Open
15 of 27 tasks

Feedback on week 7 project progress #12

nus-pe-script opened this issue Oct 2, 2018 · 1 comment

Comments

@nus-pe-script
Copy link

nus-pe-script commented Oct 2, 2018

Subject: feedback on week 7 project progress

See v1.1 progress guide for more details of the activities mentioned below.

Team progress

  • Team org and repo set up correctly (:heavy_check_mark: well done!)
  • PR created from team repo to AB-3 or AB-4 (:exclamation: try to do by next milestone)
  • Auto-publishing set up for the team repo (:heavy_check_mark: well done!)
  • README page:
    • Ui.png has been updated (:heavy_check_mark: well done!)
  • User Guide: some content has been updated (:heavy_check_mark: well done!)
  • Developer Guide: some content has been updated (:heavy_check_mark: well done!)
  • Team repo git tagged as v1.1 (:heavy_check_mark: well done!)

Individual progress of @shuanang

  • Used forking workflow:
    • Created PRs (:exclamation: try to do by next milestone)
    • Reviewed PRs (:exclamation: try to do by next milestone)
  • Merged updates to documents (:exclamation: try to do by next milestone)
  • Merged changes to java/fxml (:exclamation: try to do by next milestone)
  • shuanang.png uploaded and linked from AboutUs page, merged (:exclamation: try to do by next milestone)

Individual progress of @arjo129

  • Used forking workflow:
    • Created PRs (:heavy_check_mark: well done!)
    • Reviewed PRs (:exclamation: try to do by next milestone)
  • Merged updates to documents (:heavy_check_mark: well done!)
  • Merged changes to java/fxml (:heavy_check_mark: well done!)
  • arjo129.png uploaded and linked from AboutUs page, merged (:exclamation: try to do by next milestone)

Individual progress of @cjunxiang

  • Used forking workflow:
    • Created PRs (:heavy_check_mark: well done!)
    • Reviewed PRs (:exclamation: try to do by next milestone)
  • Merged updates to documents (:exclamation: try to do by next milestone)
  • Merged changes to java/fxml (:heavy_check_mark: well done!)
  • cjunxiang.png uploaded and linked from AboutUs page, merged (:exclamation: try to do by next milestone)

Individual progress of @TTTaus

  • Used forking workflow:
    • Created PRs (:heavy_check_mark: well done!)
    • Reviewed PRs (:heavy_check_mark: well done!)
  • Merged updates to documents (:heavy_check_mark: well done!)
  • Merged changes to java/fxml (:exclamation: try to do by next milestone)
  • tttaus.png uploaded and linked from AboutUs page, merged (:heavy_check_mark: well done!)

Tutor: @okkhoy

Note: the above observation was done by the CS2113-feedback-bot and covers changes up to 2018-10-03 02:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

@okkhoy
Copy link

okkhoy commented Oct 3, 2018

@arjo129 @shuanang @cjunxiang
Turns out, the project dashboard page requires png files. So you need to convert the images to png format. Sorry for the miscommunication.

TTTaus pushed a commit that referenced this issue Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants