Changed color label FINALLY #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITS WORKING!
Added screenshots and updated the DG
Closed
arjo129
reviewed
Oct 31, 2018
| @@ -86,6 +86,8 @@ private void loadDivePage(DiveSession dive) { | |||
| dateTime.setText(String.format(FORMAT_TIME_NOW, dive.getDateStart().getOurDateString())); | |||
| checkPressureGrp(dive.getPressureGroupAtBeginning().getPressureGroup()); | |||
| currentDive = dive; | |||
| pgStart.getStyleClass().add(checkPressureGrp(dive.getPressureGroupAtBeginning().getPressureGroup())); | |||
| pgEnd.getStyleClass().add(checkPressureGrp(dive.getPressureGroupAtEnd().getPressureGroup())); | |||
There was a problem hiding this comment.
you need to remove existing style classes too!!
| @@ -124,64 +126,65 @@ private String dateTimeSend() { | |||
| * Receives the pressure group that needs to be parsed | |||
| * sets the attribute on the screen depending on the Pressure group. | |||
| */ | |||
| private void checkPressureGrp(String pgGrp) { | |||
| private String checkPressureGrp(String pgGrp) { | |||
| switch(pgGrp) { | |||
| case "A": | |||
There was a problem hiding this comment.
You might want to check in the standard if it is possible to make this shorter.
| case "B": | ||
| break; | ||
| return "thisIsGreen"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITS WORKING!