Added more tests #108
Merged
Added more tests #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyAw
commented
Nov 10, 2018
JeremyAw
commented
- Added tests for MilestoneTest
- Updated AddMilestoneCommandTest
…into v1.3_Jeremy
…into v1.3_Jeremy
…into v1.3_Jeremy # Conflicts: # src/main/java/seedu/address/model/task/Task.java
…into v1.3_Jeremy # Conflicts: # src/main/java/seedu/address/model/task/Task.java
…into v1.3_Jeremy
…into v1.3_Jeremy # Conflicts: # src/main/java/seedu/address/model/task/Task.java # src/test/java/seedu/address/testutil/TaskBuilder.java
…into v1.3_Jeremy
…t adding of duplicate milestones
…low for a neater UI
… in more than 40 characters for each milestone description
…into v1.3_Jeremy
…into v1.3_Jeremy
…into v1.3_Jeremy
…ommandParser instead
…into v1.3_Jeremy
chel-seyy
pushed a commit
that referenced
this pull request
Feb 27, 2022
* Prevent adding of duplicate ranks when adding milestones * Sort milestones with respect to rank * Fixed minor checkstyle issues * Edited Duplicate Rank error message * Added Jeremy's Project Portfolio Page * Updated Jeremy's Project Portfolio Page * Fixed minor checkstyle issues. * Fixed the change from Set to List for milestone * Fixed merging error. * Fixed #73, updated regex for Rank * Fixed #86, updated AddMilestoneCommand to prevent adding of duplicate milestones * Implemented padding for milestone description in each Milestone to allow for a neater UI * Updated parser for AddMilestoneCommand to ensure that user cannot key in more than 40 characters for each milestone description * Created new PPP to change filename for jeremyinelysium * Added AddMilestoneCommandTest * Fixed minor checkstyle issues. * Updated Jeremy's name in AboutUs * Added tests for AddMilestoneCommandParser * Updated error messages for index and rank * Added more tests for AddMilestoneCommandParserTest to test for invalid values * Edited AddMilestoneCommand to check for invalid rank in AddMilestoneCommandParser instead * Added more tests for AddMilestoneCommandParserTest * Fixed minor checkstyle issues. * Fixed checkstyle issues by removing trailing whitespace. * Fixed minor checkstyle issues. * Added more tests for AddMilestoneCommandTest * Fixed minor checkstyle issues. * Updated tests for AddMilestoneCommandTest and added TypicalMilestones * Added tests for MilestoneTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.