Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UG/Dg, added personal portfolio. Solved deferDeadline bug, edited test case for deferDeadline and sortTask #118

Merged
merged 88 commits into from Nov 12, 2018

Conversation

ChanChunCheong
Copy link

@ChanChunCheong ChanChunCheong commented Nov 12, 2018

deferDeadline now prevents date from going over 9999
added additional test case to test for deferDeadline bug
Edited sortTask test
added PPP
updated UG/DG

emobeany and others added 30 commits September 26, 2018 18:39
* Modified aboutUs page: Ks

* Updated UG and DG for viewDate + selectDate
# Conflicts:
#	docs/DeveloperGuide.adoc
#	docs/UserGuide.adoc
#	src/main/java/seedu/address/logic/LogicManager.java
#	src/main/java/seedu/address/ui/CommandBox.java
Done AddTask + PriorityLevel with lots of refactoring
…into Midv1.2

# Conflicts:
#	docs/DeveloperGuide.adoc
# Conflicts:
#	src/main/java/seedu/address/MainApp.java
#	src/main/java/seedu/address/commons/core/Messages.java
#	src/main/java/seedu/address/commons/events/ui/PersonPanelSelectionChangedEvent.java
#	src/main/java/seedu/address/logic/LogicManager.java
#	src/main/java/seedu/address/logic/commands/AddTaskCommand.java
#	src/main/java/seedu/address/logic/commands/DeferDeadlineCommand.java
#	src/main/java/seedu/address/logic/commands/DeleteCommand.java
#	src/main/java/seedu/address/logic/parser/AddTaskCommandParser.java
#	src/main/java/seedu/address/logic/parser/CliSyntax.java
#	src/main/java/seedu/address/logic/parser/CompleteTaskCommandParser.java
#	src/main/java/seedu/address/logic/parser/ParserUtil.java
#	src/main/java/seedu/address/logic/parser/TaskBookParser.java
#	src/main/java/seedu/address/model/AddressBook.java
#	src/main/java/seedu/address/model/Model.java
#	src/main/java/seedu/address/model/ModelManager.java
#	src/main/java/seedu/address/model/deadline/Deadline.java
#	src/main/java/seedu/address/model/task/PriorityLevel.java
#	src/main/java/seedu/address/model/task/Task.java
#	src/main/java/seedu/address/model/task/UniqueTaskList.java
#	src/main/java/seedu/address/model/task/exceptions/DuplicateTaskException.java
#	src/main/java/seedu/address/ui/BrowserPanel.java
#	src/test/data/XmlAddressBookStorageTest/invalidAndValidPersonAddressBook.xml
#	src/test/data/XmlAddressBookStorageTest/invalidPersonAddressBook.xml
#	src/test/data/XmlSerializableAddressBookTest/duplicatePersonAddressBook.xml
#	src/test/data/XmlSerializableAddressBookTest/invalidPersonAddressBook.xml
#	src/test/data/XmlSerializableAddressBookTest/typicalPersonsAddressBook.xml
#	src/test/data/XmlUtilTest/invalidPersonField.xml
#	src/test/data/XmlUtilTest/missingPersonField.xml
#	src/test/data/XmlUtilTest/tempAddressBook.xml
#	src/test/data/XmlUtilTest/validAddressBook.xml
#	src/test/data/XmlUtilTest/validPerson.xml
#	src/test/java/guitests/guihandles/PersonCardHandle.java
#	src/test/java/guitests/guihandles/PersonListPanelHandle.java
#	src/test/java/seedu/address/TestApp.java
#	src/test/java/seedu/address/commons/util/XmlUtilTest.java
#	src/test/java/seedu/address/logic/LogicManagerTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandIntegrationTest.java
#	src/test/java/seedu/address/logic/commands/AddCommandTest.java
#	src/test/java/seedu/address/logic/commands/ClearCommandTest.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
#	src/test/java/seedu/address/logic/commands/EditCommandTest.java
#	src/test/java/seedu/address/logic/commands/EditPersonDescriptorTest.java
#	src/test/java/seedu/address/logic/commands/FindCommandTest.java
#	src/test/java/seedu/address/logic/commands/RedoCommandTest.java
#	src/test/java/seedu/address/logic/commands/SelectCommandTest.java
#	src/test/java/seedu/address/logic/commands/UndoCommandTest.java
#	src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/EditCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/FindCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/SelectCommandParserTest.java
#	src/test/java/seedu/address/logic/parser/TaskBookParserTest.java
#	src/test/java/seedu/address/model/AddressBookTest.java
#	src/test/java/seedu/address/model/ModelManagerTest.java
#	src/test/java/seedu/address/model/person/NameContainsKeywordsPredicateTest.java
#	src/test/java/seedu/address/model/person/PersonTest.java
#	src/test/java/seedu/address/model/person/UniquePersonListTest.java
#	src/test/java/seedu/address/storage/StorageManagerTest.java
#	src/test/java/seedu/address/storage/XmlSerializableAddressBookTest.java
#	src/test/java/seedu/address/storage/XmlTaskBookStorageTest.java
#	src/test/java/seedu/address/testutil/AddressBookBuilder.java
#	src/test/java/seedu/address/testutil/EditPersonDescriptorBuilder.java
#	src/test/java/seedu/address/testutil/PersonUtil.java
#	src/test/java/seedu/address/testutil/TestUtil.java
#	src/test/java/seedu/address/testutil/TypicalPersons.java
#	src/test/java/seedu/address/ui/BrowserPanelTest.java
#	src/test/java/seedu/address/ui/PersonCardTest.java
#	src/test/java/seedu/address/ui/PersonListPanelTest.java
#	src/test/java/seedu/address/ui/StatusBarFooterTest.java
#	src/test/java/seedu/address/ui/testutil/GuiTestAssert.java
#	src/test/java/systemtests/AddCommandSystemTest.java
#	src/test/java/systemtests/AddressBookSystemTest.java
#	src/test/java/systemtests/ClearCommandSystemTest.java
#	src/test/java/systemtests/DeleteCommandSystemTest.java
#	src/test/java/systemtests/EditCommandSystemTest.java
#	src/test/java/systemtests/FindCommandSystemTest.java
#	src/test/java/systemtests/HelpCommandSystemTest.java
#	src/test/java/systemtests/ModelHelper.java
#	src/test/java/systemtests/SampleDataTest.java
#	src/test/java/systemtests/SelectCommandSystemTest.java
#	src/test/java/systemtests/SystemTestSetupHelper.java
# Conflicts:
#	src/main/java/seedu/address/logic/LogicManager.java
#	src/main/java/seedu/address/model/task/Task.java
#	src/main/java/seedu/address/storage/XmlAdaptedTask.java
# Conflicts:
#	src/main/java/seedu/address/model/task/Deadline.java
#	src/main/java/seedu/address/model/task/Task.java
DeferDeadline, RemoveTag, SelectTag,  AddTag Command Tests.
# Conflicts:
#	src/main/java/seedu/address/logic/parser/ParserUtil.java
#	src/main/java/seedu/address/model/task/Task.java
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
# Conflicts:
#	src/test/java/seedu/address/logic/commands/CommandTestUtil.java
#	src/test/java/seedu/address/testutil/TypicalIndexes.java
@chel-seyy chel-seyy merged commit 39a681e into CS2113-AY1819S1-W13-3:master Nov 12, 2018
@ChanChunCheong ChanChunCheong changed the title Updated UG/Dg, added personal portfolio. Solved deferdeadline bug Updated UG/Dg, added personal portfolio. Solved deferdeadline bug, edited test case for deferdeadline Nov 12, 2018
@ChanChunCheong ChanChunCheong changed the title Updated UG/Dg, added personal portfolio. Solved deferdeadline bug, edited test case for deferdeadline Updated UG/Dg, added personal portfolio. Solved deferDeadline bug, edited test case for deferdeadline Nov 12, 2018
@ChanChunCheong ChanChunCheong changed the title Updated UG/Dg, added personal portfolio. Solved deferDeadline bug, edited test case for deferdeadline Updated UG/Dg, added personal portfolio. Solved deferDeadline bug, edited test case for deferDeadline and sortTask Nov 12, 2018
chel-seyy pushed a commit that referenced this pull request Feb 27, 2022
* Updated UG and DG for viewDate + selectDate (#2)

* Modified aboutUs page: Ks

* Updated UG and DG for viewDate + selectDate

* Commands to understand things better (CC)

* changed github account link

* About us - Chan Chun Cheong

* Profile Picture

* Delete profile picture.jpeg

* ChanChunCheong

* Edited About Us to enable the picture

* Edited the User Guide

* Edited the developer guide

* corrected developer guide

* Added user stories

* Added new feature: defer deadline

* Solved Merged conflict

* edited the developer guide

* edited developers guide again to solve merge conflict

* Renamed AddressBook to TaskBook

* Added Tasks + AddTask with some refactoring, still have errors in building

* Added PriorityLevel into Task

* Copied Khasim's Deadline class and teach the app to accept 'remark' but do nothing

* Teach the app to accept 'defer deadline' but do nothing (include testing)

* Added comments for better understanding.

* made some changes

* edited DG to get similar files to Org Repo master

* added back the photo

* removed test file

* added photo

* Added Tag Class

* Teach the app to accept 'SortTask' but do nothing

* Teach the app to accept 'sort' arguments but still do nothing

* reject invalid sort methods

* Module Code reflected on UI and SortTask has been implemented to UniqueTaskList

* Able to sort the task list with SortTask command. Changes reflected on UI

* Added SortTaskList to sort the task and return it back to UniqueTaskList

* Added sorting methods of priority and title

* Solved SortTask.

* Solved SortTask by priority

* Annnotated code

* Case Insensitive Command

* Test and CheckStyle are resolved.

* corrected to be the same as org_repo master

* edited the defer deadline to enable i/ dd/ mm/ yyyy/

* updated UG

* Corrected checkstyle error and edited user guide

* edited UG for Kha Sim and CC

* Final edits to deferDeadline and selectDate's UG

* addtag

* Add_tag command

* Changed TreeSet to HashSet. AddTag Command works perfectly.

* Added RemoveTag function

* Select Tag Command working. Checkstyle passed

* DeferDeadine Command changed.

* Test and CheckStyle passed

* Solved DeferDeadline bug and Added DeferDeadline Command test

* Solved removing non-existent tag bug and  tag must be alphanumeric bug.

* Solved the deferdeadline which resulted in the sametask bug. Changed the way deferdeadline is implemented

* DeferDeadline, RemoveTag, SelectTag, AddTag Command Parsers Tests.
DeferDeadline, RemoveTag, SelectTag,  AddTag Command Tests.

* Added tests for AddTag, DeferDeadline, RemoveTag.

* annotated authorship

* SortTaskCommandParser implemented

* All test cases passed

* All tests passed and checkstyle passed

* Inserted tag test and updated userguide

* removed unnecessary comments

* clean up code. Added Command Exception to deferdeadline to prevent deadline from exceeding 31/12/9999

* Edited SortTaskCommand, test and its UG

* User Guide done. Added personal project portfolio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants