Implemented AddMilestoneCommandParser #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & DG) Updated UG and DG for addTask + addDeadline
# Conflicts: # docs/DeveloperGuide.adoc # docs/UserGuide.adoc
# Conflicts: # docs/DeveloperGuide.adoc
# Conflicts: # docs/DeveloperGuide.adoc
Changed "rank" type from Integer to String in the Milestone class
Fixed minor checkstyle issues
chel-seyy
reviewed
Oct 21, 2018
chel-seyy
reviewed
Oct 21, 2018
| super(title, milestoneDescription, new PriorityLevel("high")); | ||
| //this.title = title; | ||
| //this.milestoneDescription = milestoneDescription; | ||
| this.rank = rank; | ||
| } | ||
|
|
||
| public Integer getRank() { | ||
| public String getRank() { |
There was a problem hiding this comment.
More intuitive to have rank as a int? U may consider parsingRank as a string then converting it into an integer.
…into v1.3_Jeremy
This reverts commit fe913e4.
…rent list of tasks and add milestones to that particular task
chel-seyy
reviewed
Oct 22, 2018
| @@ -15,13 +17,15 @@ | |||
| private final String description; | |||
| private final PriorityLevel priorityLevel; | |||
| private boolean isCompleted; | |||
| private final Set<Milestone> milestoneSet; | |||
There was a problem hiding this comment.
Setting milestoneSet to final means you cannot add new milestones to it, or change deadlines in the milestones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone Class: Changed "rank" type from Integer to String
Updated LogicManager
Fixed minor checkstyle issues