Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Typo fixing #44

Closed
wants to merge 2 commits into from
Closed

Conversation

dcoull
Copy link

@dcoull dcoull commented Mar 6, 2019

Partially addresses #32 - general typo and markdown typo fixing

Fixed typos in:

  • index.fsk
  • Introduction.fsx
  • Formula.fsx
  • BioItem.fsx
  • BioCollections.fsx

Copy link
Member

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dcoull, thank you for your first contribution to BioFSharp! I found a little typo in there otherwise everything looks fine.

@@ -471,7 +471,7 @@ val digestedRBCS' : Digestion.DigestedPeptide [] =
</div>
<br>
##Nucleotides
Let's imagine you have a given gene sequence and want to find out what the according protein might look like.
Let's imagine you have a given gene sequence and want to find out what the corrisponding protein might look like.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a typo slipped through here. Can you fix this one before i merge your PR?

@@ -471,7 +471,7 @@ val digestedRBCS' : Digestion.DigestedPeptide [] =
</div>
<br>
##Nucleotides
Let's imagine you have a given gene sequence and want to find out what the according protein might look like.
Let's imagine you have a given gene sequence and want to find out what the corrisponding protein might look like.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Let's imagine you have a given gene sequence and want to find out what the corrisponding protein might look like.
Let's imagine you have a given gene sequence and want to find out what the corresponding protein might look like.

@kMutagene
Copy link
Member

I really dont want to nitpick here but this would introduce a new typo for fixing an old one and this PR has gone stale. @dcoull ill close this, but please feel free to submit a new PR!

@kMutagene kMutagene closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants