-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project infra transition #7
Project infra transition #7
Conversation
…pper to magic mode *deleted old targets and commited new format
…file *added new sourcelink dependencies and validation cli *wired up xunit testing framework
…t cli tool to dotnet test hook *added editorconfig
…allation on travis
Hey, everything but one thing seems good. EDIT: The folder temp/gh-pages is usually in the gitignore and maybe isnt't even on your computer because you haven't released the docs yet. But the wording "submodule" seems quite odd. I worry this might cause problems with the gh-pages branch. |
Hi, I had a look into it and it shouldn't be a probelm. I assume the gh-pages branch could have been commited once inside the main branch. As it includes a .git directory it was most likely interpreted as a submodule - even though it was not configured as such in any other git configuration file I could find. I think the way it is now should be fine - if you'd rather have it as a submodule this can also be configured. What would you prefer? |
Seems reasonable. The git branch "gh-pages" gets cloned into the path "temp/gh-pages" when the docu gets released. So it should be the same again after the first doc release. |
Pull request as discussed in issue #2