Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project infra transition #7

Merged
merged 18 commits into from
Mar 30, 2018

Conversation

WalternativE
Copy link
Contributor

Pull request as discussed in issue #2

@HLWeil
Copy link
Member

HLWeil commented Mar 28, 2018

Hey, everything but one thing seems good.
In this commit it says that the gh-pages submodule has been removed. Do you know what could be the reason for this?

EDIT: The folder temp/gh-pages is usually in the gitignore and maybe isnt't even on your computer because you haven't released the docs yet. But the wording "submodule" seems quite odd. I worry this might cause problems with the gh-pages branch.

@WalternativE
Copy link
Contributor Author

Hi, I had a look into it and it shouldn't be a probelm. I assume the gh-pages branch could have been commited once inside the main branch. As it includes a .git directory it was most likely interpreted as a submodule - even though it was not configured as such in any other git configuration file I could find. I think the way it is now should be fine - if you'd rather have it as a submodule this can also be configured. What would you prefer?

@HLWeil
Copy link
Member

HLWeil commented Mar 30, 2018

Seems reasonable. The git branch "gh-pages" gets cloned into the path "temp/gh-pages" when the docu gets released. So it should be the same again after the first doc release.
I still don't get where the information for it being a submodule is stored though. Especially considering the whole path is in the .gitignore.
But nvm, I'll merge now. Thanks again for the effort. It's a very tidy result =)

@HLWeil HLWeil merged commit f9f1d06 into CSBiology:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants