-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented displayAchievements in UserInfo #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chievement will be displayed with the name with each achievement on one line. Added testDisplayAchievements in UserInfoTest to visualize the returned string displayAchievements.
Coco505
changed the title
implemented displayAchievements in UserInfo...so that the status of each a…
implemented displayAchievements in UserInfo
Nov 22, 2021
…p when declaring a variable
…p when declaring a variable
Add another Builtin Graph
Ming-Yeung-Alfred-Meng
approved these changes
Nov 23, 2021
DirectedGraphTest
DirectedGraphTest
update toString DirectedGraph phase 1
update Vertexrray Compare phase 1
update DirectedGraph toString phase 2
update DirectedGraph toString final
Generalizing algorithm to T
finalizing
further generalizing
…chievement will be displayed with the name with each achievement on one line. Added testDisplayAchievements in UserInfoTest to visualize the returned string displayAchievements.
… each achievement will be displayed with the name with each achievement on one line. Added testDisplayAchievements in UserInfoTest to visualize the returned string displayAchievements.
# Conflicts: # src/test/postTest.java # src/user/UserInfo.java
Sue-Tong
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the method is written well
May also write test function referring to this method
david-wei-01001
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that the status of each achievement will be displayed with the name with each achievement on one line. Added testDisplayAchievements in UserInfoTest to visualize the returned string displayAchievements.