Adding Test cases for backend #119

peeyush10234 · 2021-11-02T18:35:15Z

No description provided.

run: pylint --fail-under=1 $(find . -name "*.py" | xargs) note: set the failure threshold as indicated above actions/starter-workflows#636 (comment)

* Added CodeQL badge * Added Pylint badge * Minor edits: updated git clone steps

…5/feature-hunt into group25-workflows

All for the sake of a test badge.

group25 workflows

Revert "group25 workflows"

…up-25/feature-hunt into group25-backend-login

netlify · 2021-11-02T18:35:21Z

✔️ Deploy Preview for feature-hunt-25 ready!

🔨 Explore the source changes: 2012082

🔍 Inspect the deploy log: https://app.netlify.com/sites/feature-hunt-25/deploys/6181c2f8a1ca0000087b6b36

😎 Browse the preview: https://deploy-preview-119--feature-hunt-25.netlify.app

coveralls · 2021-11-02T18:59:08Z

Pull Request Test Coverage Report for Build 1414475856

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 24.852%

Totals
Change from base Build 1413635756:	0.0%
Covered Lines:	64
Relevant Lines:	211

💛 - Coveralls

* Restored and commented out unused tests * Added pylint skip comments

jhnguye4 · 2021-11-03T00:37:41Z

merging backend

This reverts commit 7faa72e.

snapcat · 2021-11-14T23:26:30Z

Discussion:

Peeyush — 11/02/2021
So I fixed the failing test cases on the backend side, there were 3 failing test cases for auth-controller class.
Test Name
test_login_wrong_email
test_login_missing_password
test_login_missing_email
Now we have all the test cases passing on backend

jhnguye4 — 11/02/2021
what were the failing issues for these test cases?
And what did you do to fix them?

Peeyush — 11/02/2021
For all the above three test cases, the expected response was 403 because the input response is wrong, but I was getting 200, so I first merge Emily changes into my branch and added a if condition which checks for malformed input response. Now we are seeing the expected response

Leila Moran — 11/02/2021
@ Peeyush did you add your test cases to backend or just backend-new?

Peeyush — 11/02/2021
These test cases are for auth controller class which is in present in both backend and backend-new (Copy). I am currently merging theses two directories into a single backend directory. This will stop all confusion.

Leila Moran — 11/02/2021
I'm going to restore the removed tests but have them commented out. I'm also adding pylint skip comments.

Peeyush — 11/02/2021
Actually those are hard coded tests, which tests no functionality. You can restore them if you want but they are of no use.
And thanks for the pylint skip comments

Leila Moran — 11/02/2021
I know, it's just that they were written by the previous group and I'd rather not delete any of their code if it can be helped.

Peeyush — 11/02/2021
ok fine with me, could you approve the PR after that ?

Leila Moran — 11/02/2021
@ Peeyush
Have these issues been fixed?
#111
#112

If they have, I'll link them to your PR.

Peeyush — 11/02/2021
Yes @ Leila Moran , these are resolved in this PR

* added pylint workflow w/artifacts run: pylint --fail-under=1 $(find . -name "*.py" | xargs) note: set the failure threshold as indicated above actions/starter-workflows#636 (comment) * Added CodeQL & Pylint badges, edits * Added CodeQL badge * Added Pylint badge * Minor edits: updated git clone steps * Lowered pylint failure theshold * Update and rename build.yml to coveralls.yml * Added test files to pylint.yml * Updated py files to improve pylint score * Fixed error in coveralls.yml * Removed individual tests in pylint.yml * Added pylint labels * Added test workflow * Update and rename nodejsTest.yml to nodejs.yml * Update nodejs.yml * Update nodejs.yml * Added workflow build badge to README * Added yet another workflow All for the sake of a test badge. * Added test badge * Revert "group25 workflows" * Added post to Service.js and connected login form (incomplete) * Added appropriate error messages and display for errors * Added Sign up form * Added error handling and redirecting for login and sign up * fix to react compile warning * Dashboard and tag edits are now limited by user * New tags can now be saved in the database * Adding Product Controller and Test Cases * Adding more user auth and product auth test cases * Changing gitignore * Fixing test cases for user-auth class * Removing test cases which are not used * Commented out unused tests, added pylint comments * Restored and commented out unused tests * Added pylint skip comments Co-authored-by: Leila Moran <lmmoran@ncsu.edu> Co-authored-by: Emily Tracey <etracey@ncsu.edu> Co-authored-by: peeyush10234 <ptaneja@ncsu.edu>

snapcat and others added 30 commits October 22, 2021 20:35

added pylint workflow w/artifacts

74b096b

run: pylint --fail-under=1 $(find . -name "*.py" | xargs) note: set the failure threshold as indicated above actions/starter-workflows#636 (comment)

Added CodeQL & Pylint badges, edits

ac4f5d3

* Added CodeQL badge * Added Pylint badge * Minor edits: updated git clone steps

Lowered pylint failure theshold

d7faf02

Update and rename build.yml to coveralls.yml

0596a9c

Added test files to pylint.yml

7bbf0cf

Updated py files to improve pylint score

d57e3db

Merge branch 'group25-workflows' of https://github.com/CSC510-Group-2…

30b84e0

…5/feature-hunt into group25-workflows

Fixed error in coveralls.yml

ef02a89

Removed individual tests in pylint.yml

efcf1ba

Added pylint labels

6308e16

Added test workflow

480a78e

Update and rename nodejsTest.yml to nodejs.yml

6a5bee9

Update nodejs.yml

d3fee9d

Update nodejs.yml

83d3d81

Added workflow build badge to README

c4f66e1

Added yet another workflow

09e6fa8

All for the sake of a test badge.

Added test badge

704f23d

Merge pull request #63 from CSC510-Group-25/group25-workflows

b1c94ea

group25 workflows

Revert "group25 workflows"

fd3b5ec

Merge pull request #64 from CSC510-Group-25/revert-63-group25-workflows

aa37c59

Revert "group25 workflows"

Added post to Service.js and connected login form (incomplete)

6dcec1f

Added appropriate error messages and display for errors

f50a029

Added Sign up form

b160053

Added error handling and redirecting for login and sign up

fb47993

Merge branch 'main' into group25-api-connect

48db349

fix to react compile warning

ff3cf8e

Dashboard and tag edits are now limited by user

3f56254

New tags can now be saved in the database

a43428b

Adding Product Controller and Test Cases

5399059

Merge branch 'group25-backend-login' of https://github.com/CSC510-Gro…

8f54cb3

…up-25/feature-hunt into group25-backend-login

peeyush10234 added 7 commits October 31, 2021 22:59

Adding more user auth and product auth test cases

0526cd8

Changing gitignore

7df7325

Fixing Merge Conflicts

f33d1b3

Merge branch 'group25-api-connect' into group25-backend-login

f276627

Fixing test cases for user-auth class

7e95745

Removing test cases which are not used

6e3b3c0

Merge branch 'main' into group25-backend-login

42900e2

Commented out unused tests, added pylint comments

2012082

* Restored and commented out unused tests * Added pylint skip comments

This was linked to issues Nov 2, 2021

Add test cases for backend #7

Closed

login test case with wrong input not working #112

Closed

Backend Login Test Case Failing when the password is incorrect #111

Closed

jhnguye4 approved these changes Nov 3, 2021

View reviewed changes

jhnguye4 merged commit 7faa72e into main Nov 3, 2021

snapcat added a commit that referenced this pull request Nov 3, 2021

Revert "Adding Test cases for backend (#119)"

fb1faa1

This reverts commit 7faa72e.

snapcat added a commit that referenced this pull request Nov 3, 2021

Revert "Adding Test cases for backend (#119)"

d0da7ef

This reverts commit 7faa72e.

snapcat mentioned this pull request Nov 3, 2021

Revert "Adding Test cases for backend" #122

Closed

This was referenced Nov 14, 2021

login test case with wrong input not working #112

Closed

Add test cases for backend #7

Closed

Backend Login Test Case Failing when the password is incorrect #111

Closed

snapcat linked an issue Nov 15, 2021 that may be closed by this pull request

Add test case Signup Functionality #57

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Test cases for backend #119

Adding Test cases for backend #119

peeyush10234 commented Nov 2, 2021

netlify bot commented Nov 2, 2021 •

edited

coveralls commented Nov 2, 2021 •

edited

jhnguye4 commented Nov 3, 2021

snapcat commented Nov 14, 2021

Adding Test cases for backend #119

Adding Test cases for backend #119

Conversation

peeyush10234 commented Nov 2, 2021

netlify bot commented Nov 2, 2021 • edited

coveralls commented Nov 2, 2021 • edited

Pull Request Test Coverage Report for Build 1414475856

💛 - Coveralls

jhnguye4 commented Nov 3, 2021

snapcat commented Nov 14, 2021

netlify bot commented Nov 2, 2021 •

edited

coveralls commented Nov 2, 2021 •

edited