Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage increase #172

Merged
merged 13 commits into from
Dec 31, 2020
Merged

Test coverage increase #172

merged 13 commits into from
Dec 31, 2020

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented Dec 29, 2020 •
edited
Loading

Description

tackle technical debt in unit tests and fix some bugs

Related issues

Closes #143

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  1. adding more unit tests
  2. fixed logging and description in db_service
  3. removed redundant code in operators
  4. make cookie secure if in prod
  5. full test access handler (well missing a few exceptions)

Testing

  • Unit Tests

Mentions

bringing to >89 % coverage

@blankdots blankdots added the bug Something isn't working label Dec 29, 2020
@blankdots blankdots self-assigned this Dec 29, 2020
@blankdots blankdots added this to In progress in SD Submit via automation Dec 29, 2020
Base automatically changed from feature/access-handler-tests to develop December 29, 2020 09:01
@blankdots blankdots added the enhancement New feature or request label Dec 29, 2020
@blankdots blankdots force-pushed the test/coverage-increase branch 3 times, most recently from 924f6eb to a38d96a Compare December 29, 2020 20:09
@blankdots
full test accesshandler
85ae969 
test callback validation of token
@blankdots blankdots marked this pull request as ready for review December 29, 2020 21:21
@blankdots blankdots moved this from In progress to Review in progress in SD Submit Dec 30, 2020
SD Submit automation moved this from Review in progress to Reviewer approved Dec 30, 2020
csc-jm-zz
csc-jm-zz approved these changes Dec 30, 2020
View reviewed changes
Copy link

@csc-jm-zz csc-jm-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@blankdots blankdots merged commit 4119ca7 into develop Dec 31, 2020
SD Submit automation moved this from Reviewer approved to Done Dec 31, 2020
@blankdots blankdots deleted the test/coverage-increase branch December 31, 2020 06:52
@blankdots blankdots mentioned this pull request Dec 31, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csc-jm-zz csc-jm-zz csc-jm-zz approved these changes

Assignees

@blankdots blankdots

Labels
bug Something isn't working enhancement New feature or request
Projects
SD Submit
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blankdots @csc-jm-zz