Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor mongo env vars to MONGO_ #190

Merged
merged 1 commit into from
Feb 5, 2021
Merged

refactor mongo env vars to MONGO_ #190

merged 1 commit into from
Feb 5, 2021

Conversation

blankdots
Copy link
Contributor

Description

Refactor naming convention for MONGO env vars

Related issues

Closes #188

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

1 changed MONGODB_ to MONGO_

Testing

  • Tests do not apply

Mentions

@blankdots blankdots requested a review from pontus February 5, 2021 10:56
@blankdots blankdots self-assigned this Feb 5, 2021
@blankdots blankdots added this to In progress in SD Submit via automation Feb 5, 2021
SD Submit automation moved this from In progress to Reviewer approved Feb 5, 2021
pontus
pontus approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@pontus pontus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blankdots blankdots merged commit e894818 into develop Feb 5, 2021
SD Submit automation moved this from Reviewer approved to Done Feb 5, 2021
@blankdots blankdots deleted the refactor/mongo-env-vars branch February 5, 2021 12:26
@blankdots blankdots mentioned this pull request Feb 12, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pontus pontus pontus approved these changes

Assignees

@blankdots blankdots

Labels
None yet
Projects
SD Submit
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blankdots @pontus