Feature/map datacite metadata to metax metadata #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genie9
force-pushed
the
feature/map-datacite-metadata-to-metax-metadata
branch
from
fd4cf7f
to
dcb4359
Compare
blankdots
suggested changes
Mar 31, 2022
genie9
force-pushed
the
feature/metax-integration
branch
from
bac76eb
to
4cd36fe
Compare
genie9
force-pushed
the
feature/map-datacite-metadata-to-metax-metadata
branch
from
ea3f585
to
48450ed
Compare
Open
3 tasks
blankdots
suggested changes
Apr 4, 2022
There was a problem hiding this comment.
Required change:
keywordsmight need to be adjusted to changes from keywords as list instead of array #390- (if possible) metax.json as test file for integration tests so we don't have a big object in the tests
It seems we introduced a log of .info logs, some might be required some not. Please consider that in prod we will have the log level .info so unless it is really required, it might be advisable to default to .debug log.
genie9
force-pushed
the
feature/metax-integration
branch
from
9498188
to
edb7992
Compare
genie9
force-pushed
the
feature/map-datacite-metadata-to-metax-metadata
branch
from
48450ed
to
05ab87c
Compare
blankdots
approved these changes
Apr 6, 2022
Removed pref_label from mappings as it is added by Metax. Add research_dataset.json to metax test files. Update test_doi.json.
genie9
force-pushed
the
feature/map-datacite-metadata-to-metax-metadata
branch
from
69c45b7
to
92bf5f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add a mapping between Datacite metadata and Metax metadata
Related issues
closes #327
Type of change
Changes Made
Testing
Mentions