Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow licenses #2158

Closed
3 tasks done
opqdonut opened this issue Apr 30, 2020 · 1 comment
Closed
3 tasks done

Workflow licenses #2158

opqdonut opened this issue Apr 30, 2020 · 1 comment
Assignees
Labels
Feature It's intentionally in the project Findata Organization

Comments

@opqdonut
Copy link
Contributor

opqdonut commented Apr 30, 2020

The support is there in the application model but it's not exposed by the API or UI.

  • possibility to add licenses when creating workflow
    • reuse existing workflow_licenses table? add licenses to workflow definition json?
  • attach licenses to application when creating draft
    • fetch the workflow licenses in application-created-event!

additions by @aatkin

  • workflow_licenses table probably shouldn't be used, because REMS now uses JSON blobs more widely than separate mapping tables
  • workflow definition json => workflow table workflowBody column
  • migrate workflow_licenses to workflow by wfid
@opqdonut opqdonut created this issue from a note in Rems task board (Backlog) Apr 30, 2020
@opqdonut opqdonut added this to the Findata organization review milestone Apr 30, 2020
@opqdonut opqdonut added the Feature It's intentionally in the project label Apr 30, 2020
@opqdonut opqdonut added the Findata Organization label Sep 24, 2020
@jaakkocsc jaakkocsc moved this from Backlog to User Feedback in Rems task board Mar 8, 2021
@Macroz Macroz moved this from User Feedback to Backlog in Rems task board Mar 21, 2022
@aatkin aatkin moved this from Backlog to In Progress in Rems task board Jun 10, 2022
@aatkin aatkin self-assigned this Jun 10, 2022
@aatkin aatkin mentioned this issue Jun 30, 2022
9 tasks
@Macroz
Copy link
Collaborator

Macroz commented Aug 22, 2022

We noticed that perhaps we should enable editing workflow until it is actually in use (now one can't change the form, only in creation, and one should not be able to change the licenses either).

@Macroz Macroz closed this as completed Sep 9, 2022
@Macroz Macroz moved this from In Progress to Done (newest on top) in Rems task board Sep 9, 2022
@Macroz Macroz moved this from Done (newest on top) to Accepted in Rems task board Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature It's intentionally in the project Findata Organization
Projects
Archived in project
Development

No branches or pull requests

3 participants