Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability for handler to redact attachments. #2491

Closed
7 tasks done
opqdonut opened this issue Dec 14, 2020 · 1 comment · Fixed by #3135
Closed
7 tasks done

Ability for handler to redact attachments. #2491

opqdonut opened this issue Dec 14, 2020 · 1 comment · Fixed by #3135
Assignees
Labels
Feature It's intentionally in the project Hacktoberfest

Comments

@opqdonut
Copy link
Contributor

opqdonut commented Dec 14, 2020

Sometimes the wrong attachment gets added (e.g. #2488) and needs to be redacted. We could add an API (and perhaps a UI) that would let the owner redact (i.e. zero the contents of) attachments. Redaction could also add an event to the application events, e.g. "Handler redacted attachment X".

  • implement an API to redact an attachment (like the other commands in api/applications.clj)
    • clear the attachment contents in DB, possibly in process manager
    • add new event of attachment-redacted with optional comment
  • implement action in UI for redacting an attachment similar to review action with checkboxes to filenames
  • show event and optional comment for handlers always, and to applicants if redacting an application attachment
    • If the event where the attachment came from is shown to the applicant, then the redaction should be shown too. Otherwise not.
  • Show related events could show the event from where the redacted attachment came from.
  • Attachment names should be unique (seem to be already e.g. foo (1).png, foo (2).png)

First PR could be the API with the UI later.

@opqdonut opqdonut created this issue from a note in Rems task board (Ideas) Dec 14, 2020
@Macroz Macroz added Feature It's intentionally in the project Hacktoberfest labels Sep 10, 2021
@Macroz Macroz moved this from Ideas to User Feedback in Rems task board Mar 20, 2022
@Macroz
Copy link
Collaborator

Macroz commented Mar 20, 2022

Could be that it should be the handler, in case the handler has added the document.

@jaakkocsc jaakkocsc changed the title Ability for owner to redact attachments. Ability for handler to redact attachments. Jun 20, 2022
@jaakkocsc jaakkocsc moved this from User Feedback to Backlog in Rems task board Jun 20, 2022
@aatkin aatkin moved this from Backlog to In Progress in Rems task board Oct 19, 2022
@aatkin aatkin self-assigned this Oct 19, 2022
@aatkin aatkin mentioned this issue Nov 3, 2022
9 tasks
@aatkin aatkin mentioned this issue Mar 16, 2023
12 tasks
@Macroz Macroz moved this from In Progress to Done (newest on top) in Rems task board Apr 19, 2023
@Macroz Macroz moved this from Done (newest on top) to Accepted in Rems task board Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature It's intentionally in the project Hacktoberfest
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants