Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Elections #12

Open
wants to merge 68 commits into
base: master
Choose a base branch
from
Open

Elections #12

wants to merge 68 commits into from

Conversation

CSDUMMI
Copy link
Owner

@CSDUMMI CSDUMMI commented Feb 18, 2020

Passed tests on this version with these SEEDs:

SEED=47u8888888885555iiiiiiiiii59999993n
SEED=ABnnnnnnnnnnn_________e_eIU-e
SEED=Abc:niuw 
SEED=AB²293j99999_ij_ij-ji222ßß??j

All passed after about 66 seconds.

abbashan03 and others added 30 commits January 28, 2020 17:26
@abbashan03
Use element now.
ce916dd
@abbashan03
Published and Saved Msg defined, that'll be send, once a Messages has…
748aa1f 
… been published or saved.
@abbashan03
Branches fro Read, Write, Saved and Published in update.
374e7c0
@abbashan03
Created save_page function
2eb2020 
This function saves the content of
page in the respective cache, if it
isn't already a member of those caches.
@abbashan03
Added utility functions: add_if_not_member and remove_duplicates
5a26b87
@abbashan03
Use save_page in update
6b72e00
@abbashan03
Added type alias Election.
1cf4967
@abbashan03
Added Messages.elm with decoder for Message type.
5b3b67e 
And moved Message type to Messages.elm
@CSDUMMI
Moved Messages.elm to src/
1d0c4b2
@abbashan03
Added Location of gunicorn installation to path for the execution of …
a4c17bb 
…the start script. Thus we don't need root to execute ./start
@abbashan03
mypy and static testing.
16e79e4
@CSDUMMI
Trying to implement a secure vote function, where the vote can be pub…
6374e2f 
…lished signed twice.

This is due so you can publish them encrypted and unencrypted to check 
if a user has voted and see all the votes, without associating them to a 
username.
@CSDUMMI
Implemented two step encryption in vote()
db324e3
@CSDUMMI
votes field in elections
92140e1
@CSDUMMI
Encryption of Votes
8575934
@CSDUMMI
count_votes rewritten.
52fc6bf
@CSDUMMI
class Turn created.
7aa1161
@CSDUMMI
Documentation for .el File Format
a250b54
@CSDUMMI
Changed name from generate_elections to generate_election.
b4873a6
@CSDUMMI
Added Log File mechanic
8580baa
@CSDUMMI
Added mechanic for log file in election_example.py
8c77aa2
@CSDUMMI
Writing to log file perfected.
370be14
@CSDUMMI
Stopping counting, if two options
2afda38 
both have 50%.
@CSDUMMI
Introduced variable victory threshold for election.
57e709d
@CSDUMMI
Made threshold parameter available through count_votes()as positional
9781cfb 
argument.
@CSDUMMI
Solved a bug about how self.__resort
7203639 
pops the last element of the list
automatically, thus deleting the first
choice of the vote, if called on the
original vote.
@CSDUMMI
Removed attempt at fixing bug in
0e27741 
previous commit, that is unnecessary.
@CSDUMMI
Removed election_example.py
2621fc4 
because it will be replaced by
a test file.
@CSDUMMI
Added test/election.py
44f8556 
with some test cases for Server/election.py for random ballots.
@CSDUMMI
Unit Test for Server/election.py
4c4a582
CSDUMMI and others added 9 commits February 16, 2020 17:38
@CSDUMMI
It isn't yet perfect, but good enough.
ee75ec7
@CSDUMMI
Testing for remie.
cc65db4 
Tested a little bit.
But can't find a way to determine an automated test, without just 
copying the code from vote.
Also put the test for NoneOfTheOtherOptions into vote.
@CSDUMMI
vote -> count
789bd7e 
Removed imports
@CSDUMMI
Using count in test function.
9cc1443
removed outdated tests
dc34605
Wrote unit test and got an error on
7f7f7cb 
SEED ABCDEFGHIJIkkmmMMMMMMMMMMMMMMM
because thrown_out is negative.
I suspect that the calculation of the thrown_out
is invalid or the votes somehow increased during counting,
which seems quite impossible.
@CSDUMMI
Corrected the calculation of votes and thrown_out and solved the issu…
4d5dd7a 
…e present in the previous commit.

I am going to check for three to four further SEEDs and then declare 
this branch finished, if all of them passed their tests for I have to 
return to the master branch soon enough, as this is the most important 
of all the branches if I am to say so myself.
If no further issues arise from these tests, I am glad to count this as 
the last commit on this branch.
@CSDUMMI
At last, it seems like I had overestimated my machine.
fcf6a54 
Four millions tests are wildly beyond the reach of it, so I regard it as 
a better solution for now to reduce the tests to 10⁵ each.
@CSDUMMI
Merge branch 'master' into Elections
ccad7c6
@CSDUMMI CSDUMMI added the help wanted Extra attention is needed label Feb 20, 2020
@CSDUMMI CSDUMMI added this to the Alpha phase milestone Feb 20, 2020
@CSDUMMI
Copy link
Owner Author

CSDUMMI commented Feb 20, 2020

At last, I've got the tests automatically running.
If we were to merge this, master would also always get a CI.

@CSDUMMI CSDUMMI added the critical Any and all changes to critical parts of the codebase, like elections. label Feb 21, 2020
@CSDUMMI
Copy link
Owner Author

CSDUMMI commented Feb 27, 2020

Got it. fi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abbashan03 abbashan03 Awaiting requested review from abbashan03

@moritzkreinsen moritzkreinsen Awaiting requested review from moritzkreinsen

Assignees
No one assigned
Labels
critical Any and all changes to critical parts of the codebase, like elections. help wanted Extra attention is needed
Projects
None yet
Milestone
Alpha phase
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CSDUMMI @abbashan03