Allow an initial value to be returned by the data hooks #191
Conversation
dylanwatsonsoftware
changed the title
There was a problem hiding this comment.
@dylanwatsonsoftware This looks good to me, and I'm happy with initialValue rather than defaultValue. Would you be happy to add details of the option to the README?
|
No dramas. I've had a go at adding something to the README. How's that? |
|
Thanks @dylanwatsonsoftware, this looks great. I'll get a release out shortly |
|
Wow that was fast! Thanks so much! |
|
Hi @chrisbianca I just wanted to use this feature in the current release (5.0.3) and was surprised to see that it is not part of this branch. Was there a reason for not having this as part of version 5? I have not seen any infos about this breaking change in the release notes. I would love to see this feature in v5, so could we cherry pick those changes to the master branch? Thanks, Maurice |
| @@ -123,7 +124,7 @@ const useCollectionDataInternal = < | |||
| transform | |||
| ) | |||
| ) | |||
| : undefined) as Data<T, IDField, RefField>[], | |||
| : options && options.initialValue) as Data<T, IDField, RefField>[], | |||
There was a problem hiding this comment.
If we promote this to v5, I would suggest we change this to options?.initialValue as an easier way of safe navigation
Resolves #190
As discussed, here is a PR to allow an initial value to be specified.
Questions that probably should be discussed:
I also added a github action as I find them useful.. happy to remove if its not.
Its run doesn't seem to show up in this PR but you can find it here:
https://github.com/dylanwatsonsoftware/react-firebase-hooks/runs/4581537894?check_suite_focus=true
Merging this into the v3.0.x branch as this is the one that I'm forced to use due to a bug in firebase v9.