Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve loading state #55

Merged
merged 1 commit into from
May 25, 2020

Conversation

Nickman87
Copy link
Contributor

Use reset instead of set value when no value is present
Should fix: #17

Use reset instead of set value when no value is present
@chrisbianca
Copy link
Contributor

@Nickman87 I've just belatedly merged and done some testing with this. Unfortunately, this PR has the unintended side effect that if null or undefined are passed into a hook, then the hook will forever be in the loading state.

I'm going to revert the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading: false, error: undefined, value: undefined when using useDocument
2 participants