Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, stabilize test #358

Merged
merged 17 commits into from
May 2, 2024
Merged

Update dependencies, stabilize test #358

merged 17 commits into from
May 2, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Apr 23, 2024

Changes

  • Added some development dependencies that were missing to the environment.yml
  • Upgraded owslib to >=0.29.1
  • All operations that open NetCDF files or DAP links accept an engine argument. The default for all of these is h5netcdf
  • Added pydap as an alternate backend for opening DAP links
  • test_climpred_hindcast_verif is now skipped for Python3.10 builds. It seems to only fail on the particular version of Python. When examining the dependencies, other than the Python version (and ABI version), there are no differences in the environments between Python3.10 and Python3.11. My gut feeling points to an issue with climpred.
  • Temporarily disabled tests for macOS on GitHub due to architecture changes.

@Zeitsperre Zeitsperre requested a review from huard April 23, 2024 20:53
@coveralls
Copy link

coveralls commented Apr 24, 2024

Coverage Status

coverage: 81.685% (-0.1%) from 81.788%
when pulling 97c0ed2 on fix-py310
into e90251e on master.

@Zeitsperre Zeitsperre self-assigned this Apr 24, 2024
@Zeitsperre Zeitsperre added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 24, 2024
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There's just the property argument that needs fixing.

ravenpy/config/commands.py Outdated Show resolved Hide resolved
ravenpy/config/utils.py Outdated Show resolved Hide resolved
tests/test_hindcasting.py Show resolved Hide resolved
@Zeitsperre
Copy link
Collaborator Author

@huard and @tlvu

GitHub has updated their macOS images to the ARM64 architecture. Unfortunately, this complicates our builds, as the conda-packages are only working for x86_64/AMD64. Once we can get things working again for the Raven-Hydro conda package, that should be resolved.

There was also a recent update to scikit-build-core that needs to be addressed upstream as well. Working on that now.

@Zeitsperre Zeitsperre merged commit e33769f into master May 2, 2024
14 checks passed
@Zeitsperre Zeitsperre deleted the fix-py310 branch May 2, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants