Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result set size and paging #2

Closed
mustberuss opened this issue Nov 2, 2018 · 1 comment
Closed

Result set size and paging #2

mustberuss opened this issue Nov 2, 2018 · 1 comment

Comments

@mustberuss
Copy link
Contributor

A user in the patentsview forum asked why their config file produced fewer results when their conditions were removed (*). In looking at the wrapper code, it looks like it is only using the preview of 25 results and not attempting to page through the results set.

I forked your repo and added code to address this though I don't have much experience with python. I have even less experience in making PRs and didn't know whether an issue should be created before submitting a PR out of the blue. What I added will request the api's maximum of 10,000 matches per request and will issue subsequent page requests as necessary.

(*) The user's requests looked to be of different sizes since they asked for cpc_subgroup_id and received multiple rows per patent. When this field was removed both requests generated only 25 rows.

@sarahkelley
Copy link

Thanks for point this out! Feel free to make a pull request and we will test it out and approve it (probably not until this next release cycle though).

Best,

The PatentsView Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants