-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit code returning 0 even when there are errors in css #399
Comments
Do you have a simple example this can be reproduced with? |
As in a simple example of a file? Just use any css file and change it so you know it will throw an error when you run csslint over it. When running it from a script that expects a 1 or a 0 for pass or failure (in the newer versions of node), it seems to be returning a 0 regardless of any errors being picked up by csslint. Found this as a ref - #254 |
Ah, sorry, I think this is related to #378 which is fixed, but unreleased. |
Oh cool. Thanks @nschonni! |
Hi, I noticed the lastest version in npm is 0.9.10, but the newest tag I found on github is 0.10.0. Does this release fix it and are you planning on releasing it on npm? Cheers, |
Yes, it would be nice to upgrade to 0.10.0 to npm if it has the exitstatus bug fixed. |
Using node v0.10.13 and csslint v0.9.10, running csslint on a file with errors does NOT return a 1 as expected (thus supposedly failing a build). This was functioning correctly on node v0.8.25.
The text was updated successfully, but these errors were encountered: