Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code returning 0 even when there are errors in css #399

Closed
jsango opened this issue Jul 30, 2013 · 6 comments
Closed

Exit code returning 0 even when there are errors in css #399

jsango opened this issue Jul 30, 2013 · 6 comments

Comments

@jsango
Copy link

jsango commented Jul 30, 2013

Using node v0.10.13 and csslint v0.9.10, running csslint on a file with errors does NOT return a 1 as expected (thus supposedly failing a build). This was functioning correctly on node v0.8.25.

@nschonni
Copy link
Member

Do you have a simple example this can be reproduced with?

@jsango
Copy link
Author

jsango commented Jul 30, 2013

As in a simple example of a file? Just use any css file and change it so you know it will throw an error when you run csslint over it. When running it from a script that expects a 1 or a 0 for pass or failure (in the newer versions of node), it seems to be returning a 0 regardless of any errors being picked up by csslint.

Found this as a ref - #254

@nschonni
Copy link
Member

Ah, sorry, I think this is related to #378 which is fixed, but unreleased.

@jsango
Copy link
Author

jsango commented Jul 31, 2013

Oh cool. Thanks @nschonni!

@baldo
Copy link

baldo commented Sep 19, 2013

Hi,

I noticed the lastest version in npm is 0.9.10, but the newest tag I found on github is 0.10.0. Does this release fix it and are you planning on releasing it on npm?

Cheers,
Andreas

@ddarbyson
Copy link

Yes, it would be nice to upgrade to 0.10.0 to npm if it has the exitstatus bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants