Using an ID in a selector should report first ID column #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| @@ -31,6 +32,9 @@ CSSLint.addRule({ | |||
| for (k=0; k < part.modifiers.length; k++){ | |||
| modifier = part.modifiers[k]; | |||
| if (modifier.type == "id"){ | |||
| if (!firstIdCol) { | |||
There was a problem hiding this comment.
When part.col is zero (ID is in the first selector column), then this will coerce to true on the second iteration
firstIdCol = typeof firstIdCol === "undefined" ? part.col : firstIdCol;
- Grab the col the first id was found at in a selector - Report it later instead of selector.col - Add unit tests for single and multiple ids
|
Updated
|
|
@jgable: can you fetch and rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case for this is that in the grunt-lesslint task we are using source maps to show the original less line that causes the error and since it's reporting column 0 the relevent LESS line is not as accurate as it could be.
For reference: jgable/grunt-lesslint#6