Add support for @document, @-moz-document #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add missing tests for VIEWPORT_SYM
|
+1 |
nschonni
added a commit
that referenced
this pull request
Mar 2, 2015
Add support for @document, @-moz-document
|
Thanks! |
|
No problem, happy to help out! Seems like you and the other maintainers have a lot on your plates. |
| functions: functions, | ||
| prefix: prefix, | ||
| line: token.startLine, | ||
| col: token.startCol |
There was a problem hiding this comment.
line and col are wrong: this.fire(...) should be prepended with token = tokenStream.token();
There was a problem hiding this comment.
Nice catch! Want to submit a PR with the fix?
There was a problem hiding this comment.
I figure you caught my mistake, so you deserve the credit for the fix.
There was a problem hiding this comment.
Nah, I'm afraid the PR will be stalled for a year, I have a few of the kind, so please, you submit it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53.