Responding to gabe's review

src/auth/auth.py

@@ -80,7 +80,7 @@ async def check_authentication(
 
     if session_id:
         await crud.task_clean_expired_user_sessions(db_session)
-        response_dict = await crud.check_user_validity(db_session, session_id)
+        response_dict = await crud.check_user_session(db_session, session_id)
     else:
         response_dict = {"is_valid": False}
 

src/auth/crud.py

@@ -2,6 +2,7 @@
 
 from auth import models
 
+import logging
 import sqlalchemy
 from sqlalchemy.ext.asyncio import AsyncSession
 
@@ -20,7 +21,16 @@ async def create_user_session(db_session: AsyncSession, session_id: str, computi
         query = sqlalchemy.select(models.User).where(models.User.computing_id == computing_id)
         existing_user = (await db_session.scalars(query)).first()
         if existing_user is None:
-            # @geb; throw?
+            # log this strange case
+            _logger = logging.getLogger(__name__)
+            _logger.warning("User session {} exists for non-existent user {}!".format(session_id, computing_id))
+            # create a user for this session
+            new_user = models.User(
+                computing_id=computing_id,
+                first_logged_in=datetime.now(),
+                last_logged_in=datetime.now()
+            )
+            db_session.add(new_user)
             pass
         else:
             # update the last time the user logged in to now
@@ -56,6 +66,8 @@ async def check_user_session(db_session: AsyncSession, session_id: str) -> dict:
     existing_user_session = (await db_session.scalars(query)).first()
 
     if existing_user_session:
+        # TODO: replace this select with an sqlalchemy relationship access
+        # see: https://docs.sqlalchemy.org/en/20/orm/basic_relationships.html
         query = sqlalchemy.select(models.User).where(models.User.computing_id == existing_user_session.computing_id)
         existing_user = (await db_session.scalars(query)).first()
         return {

src/auth/models.py

@@ -1,6 +1,5 @@
 from datetime import datetime
-from sqlalchemy import Column, DateTime, ForeignKey, Integer, String
-from sqlalchemy.orm import mapped_column
+from sqlalchemy import Column, DateTime, Integer, String
 # from sqlalchemy.orm import relationship
 
 from database import Base