fix: fix inconsistent queryPath accross routes

CSharperMantle · Jul 13, 2023 · d4a97f0 · d4a97f0
1 parent e8b42a9
commit d4a97f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/common/__tests__/queryPath.test.ts b/src/common/__tests__/queryPath.test.ts
@@ -63,9 +63,9 @@ describe("queryPath", () => {
         id: 1,
       },
     ] as const
-    expect(queryPath(null, 1)).toStrictEqual("#")
-    expect(queryPath(undefined, 1)).toStrictEqual("#")
-    expect(queryPath([], 1)).toStrictEqual("#")
-    expect(queryPath(routes, 1)).toStrictEqual("#")
+    expect(queryPath(null, 1)).toStrictEqual("")
+    expect(queryPath(undefined, 1)).toStrictEqual("")
+    expect(queryPath([], 1)).toStrictEqual("")
+    expect(queryPath(routes, 1)).toStrictEqual("")
   })
 })
diff --git a/src/common/queryPath.ts b/src/common/queryPath.ts
@@ -26,7 +26,7 @@ export type TRoutes = readonly TRoute[] | null | undefined
 
 export const queryPath = memoize(
   (routes: TRoutes, id: number): string => {
-    return head(filter(routes, (r) => r?.id === id))?.path ?? "#"
+    return head(filter(routes, (r) => r?.id === id))?.path ?? ""
   },
-  (_, id) => id
+  (routes, id) => [routes, id]
 )