Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject plugin imports which contain a migration which we do not know #2359

Open
ColdHeat opened this issue Jul 10, 2023 · 2 comments
Open

Reject plugin imports which contain a migration which we do not know #2359

ColdHeat opened this issue Jul 10, 2023 · 2 comments
Milestone
4.0

Comments

@ColdHeat
Copy link
Member

We should reject imports that contain alembic migrations that the CTFd instance isn't aware of.
@ColdHeat ColdHeat added this to the 3.6 milestone Jul 10, 2023
@ColdHeat
Copy link
Member Author

This actually already exists. The error that I ran into was actually importing an export which contained a plugin which was running an older version. Essentially a migration which the the CTFd plugin isn't aware of.

@ColdHeat ColdHeat removed this from the 3.6 milestone Jul 11, 2023
@ColdHeat ColdHeat changed the title Reject imports which contain a migration which we do not know Reject plugin imports which contain a migration which we do not know Jul 11, 2023
@ColdHeat ColdHeat added this to the 3.7 milestone Jul 11, 2023
@ColdHeat
Copy link
Member Author

We could possibly just enumerate all plugin migrations and then determine if we are missing a migration to import. I think that may be a bit much but it would work.

@ColdHeat ColdHeat modified the milestones: 3.7, 4.0 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@ColdHeat