Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRAN Submission #11

Closed
gabrielodom opened this issue Sep 27, 2022 · 6 comments
Closed

CRAN Submission #11

gabrielodom opened this issue Sep 27, 2022 · 6 comments
Assignees
@gabrielodom
Labels
build request add core functionality

Comments

@gabrielodom
Copy link
Contributor

We need to clean up the package directory in prep for CRAN submission.

  • I've moved inst/scripts/outcomes_by_race_20220822.R to Box/CTN0094/algorithmic_fairness/Manuscripts/CTN Endpoints Bias/
  • I've moved inst/scripts/cluster_outcomes_20220818.R to Box/CTN0094/algorithmic_fairness/Manuscripts/CTN Endpoints Clustering/
  • I've moved inst/scripts/data_files.Rmd to the repository for the ctn0094DataExtra:: package in inst/scripts/
  • I've moved the older versions of the lit review table in inst/suppl_docs/ to Box/CTN0094/algorithmic_fairness/Manuscripts/CTNote/laura_review/
  • I've moved the older versions of the calculated outcomes tables in inst/extdata/ to Box/CTN0094/algorithmic_fairness/Manuscripts/CTNote/OLD_outcomes_tables/
@gabrielodom gabrielodom added the build request add core functionality label Sep 27, 2022
@gabrielodom gabrielodom self-assigned this Sep 27, 2022
gabrielodom added a commit that referenced this issue Sep 27, 2022
@gabrielodom
Per issue #11, we're cleaning up this repo. Extraneous files are move…
8290dc2 
…d to Box/CTN0094/ subdirectories in most cases. Some files may be moved to the ctn0094DataExtra/ repo as appropriate.
@gabrielodom
Copy link
Contributor Author

More moves out:

  • vignettes/OLD/ --> Box/CTN0094/algorithmic_fairness/Manuscripts/OLD
  • vignettes/outlines_20220906.md --> Box/CTN0094/algorithmic_fairness/Manuscripts/ and renamed to CTNote_papers_outlines_20220906.md
  • vignettes/clustering_treatment_outcomes_20220923* (other than the .Rmd file) --> Box/CTN0094/algorithmic_fairness/Manuscripts/CTN Endpoints Clustering/
  • vignettes/CTNote_vignette_20220926* (other than the .Rmd file) --> Box/CTN0094/algorithmic_fairness/Manuscripts/CTNote/

@gabrielodom
Copy link
Contributor Author

Organizing vignettes/:

  • Moving vignette data down to vignettes/data/
  • Moving outcomes library files up from vignettes/endpoints_library/

gabrielodom added a commit that referenced this issue Sep 27, 2022
@gabrielodom
Per Issue #11, organizing vignettes/
0a7eae0
gabrielodom added a commit that referenced this issue Sep 27, 2022
@gabrielodom
Per Issue #11, building first draft of site with pkgdown
a655b88
@gabrielodom
Copy link
Contributor Author

We may get grief from some journals if we have the main paper drafts available as vignettes on our package website, so I'm moving them out to Box as well:

  • vignettes/clustering_treatment_outcomes_20220910.Rmd --> Manuscripts/CTN Endpoints Clustering/
  • vignettes/CTNote_vignette_20220926.Rmd --> Manuscripts/CTNote/

gabrielodom added a commit that referenced this issue Sep 27, 2022
@gabrielodom
All per Issue #11, we're tidying up the website
41325b7
gabrielodom added a commit that referenced this issue Sep 28, 2022
@gabrielodom
version bump before CRAN submission; see Issue #11
21dd3ce
@gabrielodom
Copy link
Contributor Author

gabrielodom commented Sep 28, 2022 •
edited
Loading

I moved the contents of vignettes/data/ to the Manuscripts/CTN Endpoints Clustering/ and Manuscripts/CTN Endpoints Bias/ directories.
Also, I renamed vignettes/refs/ to vignettes/bib/ to avoid confusion with any other "refs/" directories that hold PDFs of references elsewhere.

gabrielodom added a commit that referenced this issue Sep 28, 2022
@gabrielodom
hopefully the last minor organization edit before we get comments / f…
56bf9a3 
…ixes back from the CRAN review team. see Issue #11
@gabrielodom
Copy link
Contributor Author

U.L. marked the following problems (which we resolved):

  • The Description field should not start with the package name, 'This package' or similar.
  • Found the following URLs which should use \doi (with the DOI name only):
    • File 'weight_positive_visits.Rd':

gabrielodom added a commit that referenced this issue Sep 29, 2022
@gabrielodom
Per Issue #11, we are fixing issues pointed out by the CRAN review team.
c022c01
gabrielodom added a commit that referenced this issue Sep 29, 2022
@gabrielodom
Per Issue #11, fixing spelling errors.
a5fecf2
gabrielodom added a commit that referenced this issue Sep 29, 2022
@gabrielodom
per Issue #11, we've resubmitted to CRAN
6885c62
gabrielodom added a commit that referenced this issue Sep 30, 2022
@gabrielodom
Changing LWW citation hyperlinks to DOI because their articles are be…
27fd97a 
…hind a paywall and redirect too many times. More for Issue #11
gabrielodom added a commit that referenced this issue Oct 1, 2022
@gabrielodom
Per Issue #11, resubmission four
f7376f1
@gabrielodom
Copy link
Contributor Author

We're live!
https://cran.r-project.org/package=CTNote
great work everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielodom gabrielodom

Labels
build request add core functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabrielodom