Support event aliases in pmcstat #1514
Open
+34
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't have a .json pmu event description file for Morello, the pmc_pmu_enabled() check always fails and we don't use pmc_pmu_pmcallocate() which would check for aliases.
This change allows me to use events such as "cycles,usr" by saving the old suffix and restricting event aliases to not include suffixes (none of them do right now).
bsdjhb
reviewed
Oct 11, 2022
| @@ -1114,6 +1114,12 @@ pmc_allocate(const char *ctrspec, enum pmc_mode mode, | |||
| break; | |||
| } | |||
|
|
|||
| /* Try pmu_alias_get as another generic fallback/ */ | |||
| if (spec_copy == NULL) { | |||
| const char* alias_name = _pmu_alias_get(ctrspec); | |||
There was a problem hiding this comment.
s/const char* /const char */
jrtc27
reviewed
Oct 11, 2022
| @@ -175,6 +176,7 @@ static struct pmu_alias pmu_armv8_alias_table[] = { | |||
| {"BRANCH-INSTRUCTION-RETIRED", "BR_RETIRED"}, | |||
| {"BRANCH_MISSES_RETIRED", "BR_MIS_PRED_RETIRED"}, | |||
| {"BRANCH-MISSES-RETIRED", "BR_MIS_PRED_RETIRED"}, | |||
| {"cycles", "CPU_CYCLES"}, | |||
There was a problem hiding this comment.
The x86 tables in here don't have this either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't have a .json pmu event description file for Morello, the
pmc_pmu_enabled() check always fails and we don't use pmc_pmu_pmcallocate()
which would check for aliases.
If this looks reasonable, I'll send the changes upstream as well - just wanted something that unbreaks
pmc statandpmcstat -p cycleson my morello board.