Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 vmrun.sh for bhyve #2009

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Arm64 vmrun.sh for bhyve #2009

wants to merge 2 commits into from

Conversation

bsdjhb
Copy link
Collaborator

@bsdjhb bsdjhb commented Feb 10, 2024

This let me run a VM similar to what I use for amd64 as a single line:

name="installer"
tap="tap0"
sudo sh /path/to/vmrun.sh -c 1 -t ${tap} -m 4G -d /path/to/disks/${name}.img "$@" ${name}

I have not figured out the right incantation of bsd.files.mk magic to install the file. It would be simplest to add a Makefile in share/examples/bhyve I think. For upstream I would probably rename the existing vmrun.sh to vmrun.amd64.sh so it always had MACHINE_ARCH in the source file name. Not sure I wanted to do that in this downstream PR yet though.

- Use sysctl hw.vmm.destroy directly instead of bhyvectl

- Remove bhyveload and assume the u-boot firmware from pkg64

- Remove support for PCI passthrough as that is not supported on arm64

- Remove various x86-only options

- If an ISO image is used, create it as the first virtio-blk device on
  PCI slot 1
@bsdjhb bsdjhb changed the base branch from main to dev February 10, 2024 16:54
@bsdjhb bsdjhb marked this pull request as draft February 10, 2024 16:54
Copy link
Contributor

@markjdb markjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me aside from one nit. Thanks!

case $c in
a)
bhyverun_opt="${bhyverun_opt} -a"
;;
A)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we don't compile the AHCI model on CheriBSD currently.

@jrtc27
Copy link
Member

jrtc27 commented Feb 13, 2024

I'd rather have this in a port so we can update it easily (e.g. as firmware gets more featureful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants