caprevoke: Also exclude shadow bitmap from global VM stats #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise t_vmshr gives a silly number, and is what pre-3.3.0 htop uses for shared (magenta in the default colour scheme) memory in its memory meter. 3.3.0 switches to the more sensible t_rmshr given the bar is meant to reflect real, not virtual, memory, but we should still report more useful totals here.
jrtc27
requested review from
markjdb and
brooksdavis
and removed request for
markjdb
brooksdavis
approved these changes
May 10, 2024
markjdb
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise t_vmshr gives a silly number, and is what pre-3.3.0 htop uses
for shared (magenta in the default colour scheme) memory in its memory
meter. 3.3.0 switches to the more sensible t_rmshr given the bar is
meant to reflect real, not virtual, memory, but we should still report
more useful totals here.