Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing freebsd and cheribsd builds on macOS. pkg-config --exists libarchive #340

Closed
graymalkin opened this issue Jan 13, 2023 · 1 comment · Fixed by #342
Closed

Failing freebsd and cheribsd builds on macOS. pkg-config --exists libarchive #340

graymalkin opened this issue Jan 13, 2023 · 1 comment · Fixed by #342

Comments

@graymalkin
Copy link
Contributor

There is a bug in the ports install of libarchive on macOS which causes builds of cheribsd to fail when cheribuild.py checks the dependencies. Specifically, at pycheribuild/projects/cross/cheribsd.py:430. The workaround for this is documented in Homebrew/homebrew-core#117869 .

A work-around for cheribuild if this doesn't get fixed soon is to use the --modversion option for pkg-config rather than the --exists option. I'm not certain if this workaround would break things further down. The one listed on homebrew-core should behave though.
@arichardson
Copy link
Member

Ah I had no idea --exists also checked dependencies. It sounds like changing it to --modversion should be safe (unless there are dependencies we check for that don't define a version?).

graymalkin added a commit to graymalkin/cheribuild that referenced this issue Jan 17, 2023
@graymalkin
Use --modversion instead of --exists to check library is installed
f2a7ffc 
pkg-config --exists also checks dependencies are present on macOS, and
due to some packaging issues with upstream libarchive this is breaking
the build for cheribsd and freebsd.

Closes CTSRD-CHERI#340.

See Homebrew/homebrew-core#120526 for
tracking of this issue as it relates to macOS.
@graymalkin graymalkin mentioned this issue Jan 17, 2023
Merged
arichardson pushed a commit that referenced this issue Jan 17, 2023
@graymalkin
Use --modversion instead of --exists to check library is installed (#342
aa5b86e 
)

pkg-config --exists also checks dependencies are present on macOS, and
due to some packaging issues with upstream libarchive this is breaking
the build for cheribsd and freebsd.

Closes #340.

See Homebrew/homebrew-core#120526 for
tracking of this issue as it relates to macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use --modversion instead of --exists to check library is installed graymalkin/cheribuild
2 participants
@graymalkin @arichardson