Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove C++ struct calling convention hack and fix bug masked by it #393

Merged
merged 2 commits into from Apr 22, 2020

Conversation

jrtc27
Copy link
Member

@jrtc27 jrtc27 commented Apr 16, 2020

This hack causes the C and C++ calling conventions for small structs containing capabilities to differ and thus breaks code passing such structs across the language barrier.

@arichardson
Copy link
Member

Thanks! Only minor comment I have is to maybe add a commit first that autogenerates the check lines so that the bugfix commit highlights the change in the IR.

This hack causes the C and C++ calling conventions for small structs
containing capabilities to differ and thus breaks code passing such
structs across the language barrier.
@jrtc27
Copy link
Member Author

jrtc27 commented Apr 16, 2020

Thanks! Only minor comment I have is to maybe add a commit first that autogenerates the check lines so that the bugfix commit highlights the change in the IR.

Yeah that's a good suggestion, now done.

@arichardson arichardson merged commit 9d9a7a2 into dev Apr 22, 2020
@arichardson arichardson deleted the cxx-struct-cc branch May 12, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants