Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KFSPTS-31812 fix asset global doc when asset representative is not set or is non Cornell person #1609

Merged
merged 3 commits into from
May 24, 2024

Conversation

jhulslander
Copy link
Contributor

@jhulslander jhulslander commented May 22, 2024

This fix prevents an NPE when the asset representative is not set. or is not a cornell employee. It is valid for a representative to not be a Cornell employee when the asset is off site.
I looked in base code to see if this was caused by the person change or something else. I could not determine what change caused this bug to present itself. I am a little uncomfortable about that.
We were able to reproduce this bug in KualiCo Monsters' environment, it has been reported

@jhulslander jhulslander changed the title KFSPTS-31812 fix asset global doc when asset representative is not se… KFSPTS-31812 fix asset global doc when asset representative is not set or is non Cornell person May 22, 2024
@jhulslander jhulslander marked this pull request as ready for review May 22, 2024 18:05
Copy link
Contributor

@cah292 cah292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've identified the changes in base code that caused this issue; see my comment below. I'm fine with having a temporary workaround added in, though you may want to perform a quick check on other AssetLocation-related areas to see if any other quick adjustments are needed.

As for this PR's current workaround, the changes look good overall, though there are a few small areas that should be cleaned up further.

@jhulslander
Copy link
Contributor Author

Thanks Chad, that explanation makes sense. I think I have cleaned up the areas mentioned.

I found a few locations that use asset representative person object and found in the code it appears to be doing null checks as expected. It is used in asset transfer tags and JSPs, I was able to do minimal testing with those docs locally and I did not get an error. I can ask Karen to be sure to test asset transfers when validating this change.

This is ready for review again.

Copy link
Contributor

@cah292 cah292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, unit tests pass and my concerns have been addressed. Merging.

@cah292 cah292 merged commit 08333f0 into develop May 24, 2024
1 check passed
nkimble pushed a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants