-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial bucket creation capabilities and related tests #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good and seems to work: I see that the bucket and service account are created, with the appropriate permissions assigned to the new account. I have questions about how and by whom this will be used, but we can talk over that in person, perhaps. This is definitely a good start!
Thank you @falquaddoomi ! Happy to chat more about this. |
…BMI#2) * changes for assayworks project specifics * update shell script with bucket name * detemplatize; gsutil instructions * assay works docs context; simplify source dir * bucket.get svc-acct role binding * move gsutil work from .sh to .bat file Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu> * linting; remove shellcheck * rename gsutil file, remove .sh file * remove shellcheck Co-authored-by: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
* Initial commit * Add gsutil script and Assay.Works specifics (#1) * changes for assayworks project specifics * update shell script with bucket name * detemplatize; gsutil instructions * assay works docs context; simplify source dir * Move to .bat file and add Terraform role for bucket permissions (#2) * changes for assayworks project specifics * update shell script with bucket name * detemplatize; gsutil instructions * assay works docs context; simplify source dir * bucket.get svc-acct role binding * move gsutil work from .sh to .bat file Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu> * linting; remove shellcheck * rename gsutil file, remove .sh file * remove shellcheck Co-authored-by: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu> * Add multi-threading option for gsutil command (#3) * add multi-threaded option for gsutil * add docs for gsutil options * Adds documentation for Way Lab rclone usage (#4) * add way lab docs; reorganize utilities dir also add new repo diagram to increase role-based context understanding * linting change * Add Terraform state management resources and documentation (#5) * update existing tf to new location * add prep dir with state mgmt bucket * add hashicorp dir ignores * versions and lock file * rename to state-management dir * additional tf ignore * add state management instructions * state management bucket naming * single tf bucket var name * update lockfile * pre-commit image source image pin * tf backend comment * simplify state mgmt language Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu> * use specific version of dagger gh-action --------- Co-authored-by: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu> * Merge updates from 'gc-durbinlab-bucket/main' * rename and move files for template * update pre-commit deps * docs lint * ignore root terraform dir for pre-commit md lint * remove locks * data provider and receiver docs updates * poetry project updates * tf image updaet * image linting docs update * update readme for accurate role descriptions * generic bucket name replacements * update terraform provider versions + docs * Apply suggestions from code review Co-authored-by: Faisal Alquaddoomi <falquaddoomi@gmail.com> * add note about service account credential location * ignore the tf created svc account credential file --------- Co-authored-by: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu> Co-authored-by: Faisal Alquaddoomi <falquaddoomi@gmail.com>
This PR includes initial work to enable Terraform Google Cloud bucket creation capabilities for this template repository.
Note: some of my intent was to containerize the deployment capabilities within Dagger but this might have impacted the development timeline and added more complexity to the work found here. I've spurred #1 into place to explore this work in the future.
Thanks in advance for any suggestions or comments you may have!