New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week 5 Problem Set #6
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
first edit on week5 nb
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This intro section looks good! Only thing is that I notice some words capitalized that I don't think need to be; if the intention is to provide emphasis on those terms as vocab words, maybe use italics or boldface instead?
Also, in the paragraph that starts "In this form, the S-B equation compares...", you're missing a closing parenthesis in the second sentence.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to "Austrian" or do you mean in the Background section when I have "Watts", etc.?
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can shorten this line of code a bit by doing constants['Radius1'] ** 2
Reply via ReviewNB
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the lines separating questions! How'd you do that?
On question 2, you say "Create a variable and list of values of your own..." - I think what you want them to create is a dictionary (which is different from a list in python).
In question 4, the conversion from Kelvin to C could be formatted using LaTeX
Reply via ReviewNB
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above for question 2 - what they create is a dictionary, not a list
Reply via ReviewNB
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In question 4, between steps 2 and 3, you cancel piR^2. But what happens to the 4 in the denominator (with 4piR^2?) I'm probably missing something really obvious...
Reply via ReviewNB
@@ -0,0 +1,366 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my Week 5 Problem Set:
https://mybinder.org/v2/gh/CUB-Computational-Tools/2020-ps-jolsenvaldez/binder-python?urlpath=git-pull?repo=https%3A%2F%2Fgithub.com%2FCUB-Computational-Tools%2F2020-ps-jolsenvaldez%26branch%3Dweek5%26urlpath%3Dlab