Release 2019.03 #155
Merged
Release 2019.03 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: rewrite some message strings (#22) * Sort jdbc drivers (#21) This fix solves the issue with the JDBC driver ordering in the Preferences/JDBC Management tab. At first, they were ordered alphabetically and that was not desired, so I have ordered them based on the version number. TableViewerSorter.java now contains a hashmap that can have an arbitrary comparator for each table column (the key of this hashmap is the column value). When sorting a column, I check whether the hashmap contains a comparator for that column or not and, if it exists, use it. * deleted wrong characters in ko_KR messages (#26) trivial change. so merge directly. * CloseQueryEditor: if all tabs are closed, start sqlEditorCounter at 1 (#25) seunghun-kim reviewed, tested and confirmed it operated as expected. * Repair strings (#24) * RepairStrings: repair mistakes in labels/buttons * RepairStrings: update gitignore to ignore metadata * RepairStrings: revert gitignore * Scroll drivers list (#23) * master: create separate class (MessageDialogWithScrollableMessage) # Conflicts: # com.cubrid.common.ui/src/com/cubrid/common/ui/spi/util/CommonUITool.java * master: add scrollable window with the drivers list * ScrollDriversList: repair git mistake * ScrollDriversList: fix another merging mistake * ScrollDriversList: replace "OK" with Messages.btnOk * ScrollDriversList: choose whether you show informative message or informative message + scrollable text when opening an information box. * ScrollDriversList: remove some unused imports * ScrollDriversList: small improvement * ScrollDriversList: remove a couple of double lines * ScrollDriversList: change the same of two variables * ScrollDriversList: remove redundant setLayout. format code * ScrollDriversList: delete {0} from jdbcDriverDownloadSuccessMsg. change the way we build the downloadedFiles string * UIImprovements: -remove superfluous message from the jdbc advanced op… (#27) * UIImprovements: -remove superfluous message from the jdbc advanced options (load jdbc driver) -remove superfluous message that appeared when clicking File->Open SQL File or File->Save all SQL files (Setting SQL file charset). * RemoveMessages: restore messages * UIImprovements: transform 1th, 2th and 3th to their correct spelling (#28) * UIImprovements: transform 1th, 2th and 3th to their correct spelling * OrdinalNumbers: repair strings for some locales * OrdinalNumbers: fix typo * OrdinalNumbers: locale improvements * OrdinalNumbers: locales are now enums * OrdinalNumbers: remove unused import * OrdinalNumbers: refactor for messages in query * OrdinalNumbers: make the change for task_querydesc * UIImprovements: -fix the tools->broker log_top to excel labels (they weren't centered) (#29) * fixed that elapsed time was printed as twice (#34) * Search button (#31) * UIImprovements: -fix the "search in cubrid.org" button * SearchButton: remove the hardcoded stuff * SearchButton: remove unused imports * Auto layout button (#33) - UIImprovements: make the "auto layout" button's height bigger to that the inner text is shown correctly * AutoLayoutButton: remove hard coded stuff * AutoLayoutButton: make the font smaller * AutoLayoutButton: -don't resize the whole toolbar. -don't decrease font's size -put the marginHeight to 0 * AutoLayoutButton: unused import * FixSearch: add useful keywords to search in preferences (#35) * ExecuteSQLWindow: fix the query text box (#36) * Bytes: change from X to XB (X={K, M, G, T}) (#37) * Repair strings2 (#46) * RepairStrings2: spell Excel with capital letter * RepairStrings2: -add OBS to the export types -do not prefix “:” with a space -seperator->separator * RepairStrings2: not exist->inexistent * RepairString2: "the information" * RepairStrings2: byte->bytes * RepairStrings2: separate equals from argument and message * RepairStrings2: improve the errNoSelectedTable message * RowToColumnGood: rename some strings (#32) * RowToColumnGood: rename some strings * RowToColumnGood: change from row to column. disable inspect column if necessary * Enhancement for Export function (#43) * export enhancement: apply to SQL, CSV, XLS, TXT files * export enhancement: apply to loaddb type * export enhancement: delete unnecessary codes * export enhancement: refine export datas and delete handling columns * export enhancement: delete where condition that is duplicated * export enhancement: deleted subtree check logic * export enhancement: corrected the typo in messages class * export enhancement: <> diamond is not support before 1.7 java * export enhancement: moved getSelectSQL(), getColumnList() to QueryUtil * export enhancement: replaced StringBuffer to StringBuilder because unnecessary thread safe class. * export enhancement: moveed totalRecord checking under the table checking * ShowDashboard: add \n to message so it splits (#44) * ShowDashboard: add \n to message so it splits * ShowDashboard: revert the message and add SWT.WRAP to the button * Merge Release/2016.12 to develop (#47) * cannot execute a query that it has a sqlmap syntax tags (#41) * cannot execute a query that it has a sqlmap syntax tags When the query has sqlmap tags such as <select>, <update>, <insert>, <delete>, cubrid manager expects to parse as well as transform that query to a normal query which allows to be executed in the query editor through parameter binding step. However, some query might possible to have such tags in conditions. In this condition, when you run a query, it couldn't execute because cubrid manager handles that query as a sqlmap rather than a normal query. So, it is always failed. For this reason, we should have to provide sqlmap parsing function with an extra action rather than a query run action. Because even if it has a function to distinguish between a normal and a sqlmap query in the query editor, but it is not enough with such simple logic. In this patch, I added a new menu item in the context menu of the query editor as `Parse this sqlmap query` which located under the `Run this query` menu item. When you click this menu, it will parse the query as the sqlmap and make it open the Sqlmap pane on the right side of the query editor due to binding parameters. * update version information for build. From 9.3.6.005 to 9.3.6.005. * When running query which contains null data in LOB types, CM was hanged. (#48) * added logic for checking NullPointerException in cache * separate the method about dispose() for cache handling * Wrong pk icon in the navigation tree (#49) * fixed wrong pk column shown in host navigator * moved getPrimaryKeys() to QueryUtil * deleted unnecessary variable * RepairStrings3: improve some messages, as they included redundancies. (#54) * Cubrid project site url (#55) * CubridProjectSiteUrl: jira->github * CubridProjectSiteUrl: change report bug redirect * Escaping quotation in copy Insert and Update (#56) Escaping quotation when executing COPYnPASTE operation on Insert and Update statement * fix ArrayIndexOutOfBound in loadClobData() (#57) adding exceptional case. LGTM * update version information for build This update is for release/2017.01. * Fix typo and additional escaping quotes in "selected row > copy Insert & Update" (#59) trivial fix and urgent fix * update version information for build Changed build version 9.3.6.006 to 9.3.6.007. * Fix db space (#62) * FixDbSpace: whole fix * FixDbSpace: change after remzi's review * FixDbSpace: volumeinfo -> spaceinfo * FixDbSpace2: refactor, eliminate if version... * FixDbSpace2: remove duplicate code * FixDbSpace2: small change * FixDbSpace2: delete folder class, add file DbSpaceInfo * FixDbSpace2: remove spaces * FixDbSpace2: delete space * FixDbSpace2: add space * FixDbSpace2: paint pie chart for 10.1 * Fixed invalid unit in config property (#63) * #19 unable to locate its companion shared library error on mac os sierra (#64) * #19 unable to locate its companion shared library error on mac os sierra - add .DS_Store file to decorate dmg image - add dmg file build script - make the app open with a proper workspace path, named as `CUBRIDManager` in the Documents folder of the user home on mac osx * - fix a background image issue * Service dashboard bug (#65) * ServiceDashboardBug: don't let duplicate hosts (port, address and username) * ServiceDashboardBug: fix an added bug * ServiceDashboardBug: also fix a label * ServiceDashboardBug: differentiate between connect and edit actions using a boolean * ServiceDashboardBug: remove the HashMap in ServerMananger, replace it with the list in the CMHostNodePersistManager class * CyclicDep: remove nasty cyclic dependency * CyclicDep: uncomment CMServiceAnalysisAction's run. * CyclicDep: remove garbage from eclipse * CyclicDep: make CMHostNodePersistManager the only class responsible for host manipulation. horrible workaround to remove cyclic dep: now ServerManager only has "setConnected" and "isConnected" for hosts. * CyclicDep: remove exported=true * CyclicDep: move a line * Service dashboard bug - refactored CMHostNodePersisterManager, ServerManager due to cyclic dependency issue * Table and Column's upper case issue in _cub_schema_comments (#67) * change query for _cub_schema_comments * delete duplicated codes * added LOWER() when executing update _cub_schema_comments * delete duplicated codes in UpdateDescriptionTask() * Fix the error of Edit Broker Config (#66) * change validate method in BrokerConfigEditComposite * changed to for more readability * changed to isBlank() for more readability * changed displaying result about command (#68) * Support the feature of comment in DB Server since 10.0 (#70) * add isAfter100 and isCommentSupports to CompatibleUtil * update loadDescription for version 10.x * add msg about not support installing comment in 10.x * update deleteDescription for 10.x * update updateDescription for 10.x * fixed bug which empty string is not applied in Edit Table * fix NullPointerException when select tables in navigator * support synchronize comment in ERD for 10.x * support create comment to sql in ERD for 10.x * separated generateSyncCommentSQL for each interests * Support the Index's comment in DB Server since 10.0 (#71) * add column for memo to index tabl * implement getting comment for db objects * displaying comments into the view about indexes * add index memo to the Add Index Constraint * add comment when generating create index statement * fix JDBC Error in CUBRID before 10.0 * add message for index memo * add deleted message * Support the View's comment in DB Server since 10.0 (#72) * add column for memo to view property * fix typo * add getting comment in init() * fix invalid argument exception when using system view * add comment for each columns of the view * implement getting comment for each columns of the view from db * implement applying the view's comment when OK button pressed * Support the SP's comment in DB Server since 10.0 (#73) * add memo columns in the view of add/edit for SP * add memo column to the view of add/edit parameter * change the query to enable selecting comment for SP * implement showing comment in create/edit view * implement saving comment to SP * fix NullPointerException in EditFunctionDialog * Support the Trigger's comment in DB Server since 10.0 (#74) * add messages for comment * add comment column to create/edit trigger * impement generating sql for trigger when user updated trigger * implement displaying comment to the view about trigger * fix testcases's error about comment of SP (#75) * add def_order to the query for getting table's columns (#76) * Fix binding error when using type of bit in import feature (#77) * fix binding error when using type of bit in import feature * refactoring about converting bit to bytes * delete useless imported package * Support the Serial's comment in DB Server since 10.0 (#78) * add variable for description to the message files * add Serial memo to the Create / edit Serial view * implement displaying comment to the view * add comment statement to the SQL Script view * add modifyListener to the column of Serial's comment * implement create/edit Serial to the DB * Support the User's comment in DB Server since 10.0 (#79) * add variable for comment of user * add column for comment of user to the create/edit view * implement getting comment from db for user * implement saving comment to the db server for user * Support the Partition's comment in DB Server since 10.0 (#80) * add variables for partition's memo * add checking variable for feature of comment * add column for partition's memo UI * implement getting comment from db * implement generating sql about comment of partition * add column for comment to Edit Partition of list partitioning * implement showing comment to the Edit Partition View * add modifyListener for column of comment * update performFinish() for list partitioning comment * add column for comment to Edit Partition of range partitioning * implement showing comment for range partitioning * update performFinish() for range partitioning comment * fix NullPointerException in version lower than 10.0 * add checking logic for 10.1 (#81) * Fix the bug about export all the results to a file (#82) * add getSelectSQL method * replace QueryUtil.getSelectSQL to the getSelectSQL * update StyledText of view is scrollable (#83) * delete the autocommit setting in Preferences (#84) * disable Notice Dashboard (#85) * Correction of typo for Korean in job automation (#86) * update typo in query plan when setting job automation * update another typo in query plan of job automation * Add README.md (#87) * add readme.md * Update README.md * BOM processing in the import feature (#88) * create new method for removing BOM in StringUtil * apply StringUtil.removeBOM() to the import features * update version.properties for release/2017.06 (#89) * update jdbc drivers which were added recently (#92) * fix NullPointerException when table of _cub_schema_comments is not exists (#91) * update version string (#93) * change setVersion() using regex (#95) * Apply function based index (#96) * create checking methods for function index in CompatibleUtil * apply function index when using schema compare wizard * apply function index in navigation tree * apply function index in edit table * Function-based index should create and update as GUI (#98) * create checking methods for function index in CompatibleUtil * apply function index when using schema compare wizard * apply function index in navigation tree * apply function index in edit table * add checking method for function-based index * separate saving column name and rule * update for function-based index item setting * change hard coded title to variable * apply creating function-based index usnig reverse index (#101) * change logics about find aggregate function (#102) * [TOOLS-4268] Configuration error in cubrid.conf due to Byte unit (#103) * change regex for byte unit * change variable name as more readable * change the logics about setting units * [TOOLS-4269] 'unload' do not works properly (#104) * delete the duplicate codes * change the JSON parser for selected classes in unloaddb * [TOOLS-4270] CM blocked when MAX CAS connection is reached (#105) * add method about check for available connections * add variable for represent on error dialog * add logic for checking connection is available * [TOOLS-4270] Open the query editor is limited by value of MAX_NUM_APPL_SERVER and IDLE CAS (#106) * implement the counting method for available cas in ServerInfo * apply counting CAS method when open the query editor * add getBrokerName method in DatabaseInfo * update isAvailableConnect() in QueryEditorUtil * apply releasing cas count when closed the query editor * apply releasing cas count when log out the database * update releaseCasCount() and delete releaseAllCasCount() * release the cas for target database when logout * change the method's name and return type * implement isExistIdleCas() for checking idle cas * [TOOLS-4270] Enhancement to open the query editor. (#107) * change the isAvailableConnect() for real time cas usage * rollback the codes which related with 167efff * Added logic to ensure that query editor is open and running (#108) * update version.properties for release/2017.08 (#109)
CM version update (10.1.0.0004)
* [TOOLS-4304] Modify/Remove broken link in README * [TOOLS-4304] Removed unnecessary link
…database objects in 'loaddb' format (#136) * [TOOLS-4299] Moved method to create the serial into the core package * [TOOLS-4299] Write the serial to the schema file when using loaddb format * [TOOLS-4299] Changed String to the StringBuilder for performance * [TOOLS-4299] added semicolon to notice the termination of creating the serial * [TOOLS-4299] added isLoadDB parameter to the exportSchemaToOBSFile() The exportSchemaToOBSFile() is used to export the schemas at the all formats like sql, csv, xlsx, txt and loaddb. So we added isLoadDB parameter to check the caller who called this method because the serial will be exported as twice when export the format except loaddb. * [TOOLS-4299] added trigger UI in setting for export feature for LoadDB * [TOOLS-4299] added new messages for export UI * [TOOLS-4299] updated new messages for trigger in the ExportSettingForLoadDBPage * [TOOLS-4299] added trigger UI in setting for export feature for other formats * [TOOLS-4299] Showing trigger when export is progressed * [TOOLS-4299] Implement the exporting for trigger * [TOOLS-4299] Added trigger info to the ExportDataViewPart * [TOOLS-4299] Added trigger event handler to the catch clause in the ExportSchemaThread class * [TOOLS-4299] Added counting for trigger at the progress manager * [TOOLS-4299] Fixed NullPointerException when generate DDL of trigger * [TOOLS-4299] Fixed invalid casting when export the datas * [TOOLS-4299] Removed unnecessary task - JDBCGetTriggerInfoTask
…UBRID Navigator View (#137) * [TOOLS-4308] Add a condition to WHERE clause * [TOOLS-4308] Add ORDER BY Clause
* modified: version.properties CM verstion update (10.1.0.0004 / 2018.06) * Changes to be committed: modified: version.properties update version buildVersionId=10.1.0.0004 -> buildVersionId=10.1.0.0005 for ready to release 2018.09
* modified: version.properties CM verstion update (10.1.0.0004 / 2018.06) * Changes to be committed: modified: version.properties update version buildVersionId=10.1.0.0004 -> buildVersionId=10.1.0.0005 for ready to release 2018.09
… a database (#145) * [TOOLS-4313] [CM] Set the default charset as ko_KR.utf8 when creating a database * [TOOLS-4313] change a method name
…t Navigation' windows (#150) * [TOOLS-4319] add messages for grpNavigator, lblTablesFetchSize * [TOOLS-4319] add getter, setter for tablesFetchSize * [TOOLS-4319] add navigatorGroup * [TOOLS-4319] change MAX_TABLE_COUNT=100 to tableFetchSize from GeneralPreference * [TOOLS-4319] add navigator preference * [TOOLS-4319] add navigator preference page * [TOOLS-4319] add navigator name * [TOOLS-4319] Change GeneralPreference to NavigatorPreference * [TOOLS-4319] remove label, combo components for tableFetchSize * [TOOLS-4319] add Navigator Preference page ID to compare * [TOOLS-4319] remove tables fetch size item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
[TOOLS-4320] When a user try to change the database under multiple query editors were opened, CM always changes the database associated with the query editor latest created. (#151)
[TOOLS-4313] Set the default charset as “ko_KR.utf8” when creating a database (#145)
[TOOLS-4319] Change properties of unfolding 'Table' icon in 'Host Navigation' windows (#150)
Bug Fixes
[TOOLS-4309] Side effect of #126: system table list is attached while unfolding table view, which is unintended (#144)
[TOOLS-4317] If 'oracle_style_empty_string=yes' is added in cubrid.conf, Tables are not shown in the CM Navigator View. (#148)
[TOOLS-4314] Wrong table count is shown when a user expands the table (#146)
[TOOLS-4316] CM Hangs when right-mouse-button is clicked over a connection history in 'Query Mode' which contains IP address currently not reachable. (#147)
[TOOLS-4321] When a user expands "More Tables" node, all table folders' table count is updated. (#152)