[CBRD-20403] update CMakeList.txt to fix generating libbrokeradmin #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared library and link generate libbrokeradmin shared library version information
|
Would you review the fix? |
|
@gwangil-choi only a commit ffd2c41 is related with this issue. please check your other commits. |
|
@gwangil-choi |
|
@xkyu I got it. thanks. |
ribram
pushed a commit
to ribram/cubrid
that referenced
this pull request
May 21, 2021
* [SC-328] MSVC Warnings. remove unused labels & variables (CUBRID#116) https://arniadb.atlassian.net/browse/SC-328 NOTE: some whitespace changes after merging from develop + indent&astyle * remove unused labels & variables * fix: max_process_size * [SC-329] MSVC Warnings. signed/unsigned mismatch (CUBRID#117) https://arniadb.atlassian.net/browse/SC-329 * remove warning C4018: '<': signed/unsigned mismatch * style: spaces between function name and arg list * [SC-330] MSVC Warning. size_t to [const] [unsigned] int (CUBRID#118) https://arniadb.atlassian.net/browse/SC-330 * remove warning: size_t to [const] [unsigned] int * style: space between function name & arg list * [SC-331] MSVC Warnings. SOCKET to int (CUBRID#119) https://arniadb.atlassian.net/browse/SC-331 fix build warning: SOCKET to int * remove unused labels & variables * remove warning C4018: '<': signed/unsigned mismatch * remove warning: size_t to [const] [unsigned] int * remove warning: SOCKET to int * remove external file (.vscode/settings.json) commited by mistake * use STATIC_CAST instead static_cast<> in .c files * [SC-332] MSVC Warning. _Rep to int (CUBRID#120) https://arniadb.atlassian.net/browse/SC-332 fix build warning: cast _Rep to int * remove unused labels & variables * remove warning C4018: '<': signed/unsigned mismatch * remove warning: size_t to [const] [unsigned] int * remove warning: SOCKET to int * fix warning: cast _Rep to int * remove external file (.vscode/settings.json) commited by mistake * use STATIC_CAST instead static_cast in .c files * [SC-333] MSVC Warnings. unsafe mix of types (CUBRID#121) https://arniadb.atlassian.net/browse/SC-333 fix warning C4805: '!=': unsafe mix of type 'char' and type 'bool' in operation * use STATIC_CAST instead static_cast in .c files * [SC-334] MSVC Warnings. double to (u)int(64) (CUBRID#122) https://arniadb.atlassian.net/browse/SC-334 fix warning C4244: '=': conversion from 'double' to 'int', possible loss of data * use STATIC_CAST instead static_cast in .c files * [SC-338] MSVC Warnings. int64 to int https://arniadb.atlassian.net/browse/SC-338 fix warning C4244: '=': conversion from '__int64' to 'int', possible loss of data * [SC-339] MSVC Warnings. cast float to int (CUBRID#126) https://arniadb.atlassian.net/browse/SC-339 * fix warning: float to int * [SC-340] MSVC Warnings. cast time_t to int (CUBRID#127) https://arniadb.atlassian.net/browse/SC-340 fix warning C4244: '=': conversion from 'time_t' to 'int', possible loss of data * fix warning C4244: '=': conversion from 'time_t' to 'int', possible loss of data * fix gcc err: DWORD->unsigned * [SC-341] MSVC Warnings. sprintf format (CUBRID#128) https://arniadb.atlassian.net/browse/SC-341 fix warning C4477: 'sprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 1 has type 'CString' * fix warning C4477: 'sprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 1 has type 'CString' * use format macro PRId64 to printf std::chrono::milliseconds on both platforms * [SC-342] MSVC Warnings. switch no case (CUBRID#129) https://arniadb.atlassian.net/browse/SC-342 fix warning C4065: switch statement contains 'default' but no 'case' labels * fix warning C4065: switch statement contains 'default' but no 'case' labels * [SC-343] MSVC Warnings. getpid (CUBRID#130) https://arniadb.atlassian.net/browse/SC-343 warning C4005: 'getpid': macro redefinition * fix warning C4005: 'getpid': macro redefinition * [SC-350] MSVC Warnings. remove deprecated flg -Og- CUBRID#136 https://arniadb.atlassian.net/browse/SC-350 remove deprecated compiler warning -Og- * [SC-351] MSVC Warnings. fix warning C4309: '=': truncation of constant value (CUBRID#137) https://arniadb.atlassian.net/browse/SC-351 warning C4309: '=': truncation of constant value * fix warning C4309: '=': truncation of constant value * fix Windows/Linux builds * use IS_INVALID_SOCKET() on both platforms * CLOSE_SOCKET() * cleanup * [SC-355] MSVC Warnings. streampos to int (CUBRID#141) https://arniadb.atlassian.net/browse/SC-355 warning C4244: 'return': conversion from 'std::streamoff' to 'int', possible loss of data * fix warning C4244: 'return': conversion from 'std::streamoff' to 'int', possible loss of data * revert changes in cubrid_opt.h * [SC-344] is_bind_with_size(): fix buffer overflow when len==sizeof(size) CUBRID#154 https://arniadb.atlassian.net/browse/SC-344 * [SC-336] cubreplication::master_node::new_slave|add_ctrl_chn(int->SOCKET) (CUBRID#161) https://arniadb.atlassian.net/browse/SC-336 both new_slave() and add_ctrl_ch() receive a SOCKET parameter => makes sense to the same type without any cast WINDOWS: need to include WinSock2.h but this indirectly defines min() & max() macros and collide with std::numeric_limits::min&max used in heart_beat_cluster.hpp (where I included the necessary header) solution was to add compiler definition to inhibit min&max definition (NOMINMAX) NOMINMAX was already defined in CMakeLists.txt but as an environment variable without effect on preprocessing headers; it doesn't look like it is needed => removed it LINUX: SOCKET used as type alias in replication_master_node.hpp a proper solution would be a platform independent Socket wrapper (C++, RAII, automatic casts, etc) * cubreplication::master_node::new_slave(int->SOCKET) * fix SOCKET on Linux? a platform independent socket wrapper needed! * CMakeLists.txt: remove "set(NOMINMAX 1)" because it was replaced with a proper compiler definition * remove unnecesary changes * remove unrelated change * [SC-335] use size_t in or_pack_string_with_length(), or_packed_string_length() CUBRID#155 https://arniadb.atlassian.net/browse/SC-335 request to use size_t was only for or_pack_string_with_length() but I extended it also to or_packed_string_length() because the 1st one uses the output parameters from the 2nd one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update CMakeList.txt to fix generating libbrokeradmin shared library and link and version number